Skip to content

Commit 638b0fb

Browse files
committed
fix open command
1 parent e50c636 commit 638b0fb

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

packages/selianize/__tests__/command.spec.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,7 +41,7 @@ describe("command code emitter", () => {
4141
target: "/",
4242
value: ""
4343
};
44-
return expect(CommandEmitter.emit(command)).resolves.toBe(`await driver.get(BASE_URL + "${command.target}");`);
44+
return expect(CommandEmitter.emit(command)).resolves.toBe(`await driver.get((new URL("${command.target}", BASE_URL)).href);`);
4545
});
4646
it("should emit `open` with absolute url", () => {
4747
const command = {

packages/selianize/__tests__/testcase.spec.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -46,7 +46,7 @@ describe("test case code emitter", () => {
4646
id: "1",
4747
name: "example test case",
4848
test: `it("${test.name}", async () => {await tests.example_test_case(driver, vars);await driver.getTitle().then(title => {expect(title).toBeDefined();});});`,
49-
function: `tests.example_test_case = async function example_test_case(driver, vars, opts) {await driver.get(BASE_URL + "${test.commands[0].target}");}`
49+
function: `tests.example_test_case = async function example_test_case(driver, vars, opts) {await driver.get((new URL("${test.commands[0].target}", BASE_URL)).href);}`
5050
});
5151
});
5252
it("should emit a test with multiple commands", () => {
@@ -75,7 +75,7 @@ describe("test case code emitter", () => {
7575
id: "1",
7676
name: "example test case",
7777
test: `it("${test.name}", async () => {await tests.example_test_case(driver, vars);await driver.getTitle().then(title => {expect(title).toBeDefined();});});`,
78-
function: `tests.example_test_case = async function example_test_case(driver, vars, opts) {await driver.get(BASE_URL + "${test.commands[0].target}");await driver.get(BASE_URL + "${test.commands[1].target}");await driver.get(BASE_URL + "${test.commands[2].target}");}`
78+
function: `tests.example_test_case = async function example_test_case(driver, vars, opts) {await driver.get((new URL("${test.commands[0].target}", BASE_URL)).href);await driver.get((new URL("${test.commands[1].target}", BASE_URL)).href);await driver.get((new URL("${test.commands[2].target}", BASE_URL)).href);}`
7979
});
8080
});
8181
it("should reject a test with failed commands", () => {

packages/selianize/src/command.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -144,7 +144,7 @@ export default {
144144
};
145145

146146
function emitOpen(target) {
147-
const url = /^(file|http|https):\/\//.test(target) ? `"${target}"` : `BASE_URL + "${target}"`;
147+
const url = /^(file|http|https):\/\//.test(target) ? `"${target}"` : `(new URL("${target}", BASE_URL)).href`;
148148
return Promise.resolve(`await driver.get(${url});`);
149149
}
150150

0 commit comments

Comments
 (0)