Skip to content

Commit 78d0273

Browse files
mattonemtoddtarsi
authored andcommitted
We should use appropriate asserts.
It makes better exception message and more accurate assertions.
1 parent 02ac35f commit 78d0273

File tree

1 file changed

+6
-6
lines changed
  • packages/code-export-javascript-mocha/src

1 file changed

+6
-6
lines changed

packages/code-export-javascript-mocha/src/command.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -848,7 +848,7 @@ async function emitVerifyNotSelectedValue(locator: string, expectedValue: string
848848
},
849849
{
850850
level: 1,
851-
statement: `assert(value !== "${exporter.emit.text(expectedValue)}")`,
851+
statement: `assert.equal(value, "${exporter.emit.text(expectedValue)}")`
852852
},
853853
{ level: 0, statement: `}` },
854854
]
@@ -864,7 +864,7 @@ async function emitVerifyNotText(locator: string, text: string) {
864864
locator
865865
)}).getText()`,
866866
},
867-
{ level: 1, statement: `assert(text !== "${exporter.emit.text(text)}")` },
867+
{ level: 1, statement: `assert.notEqual(text, "${exporter.emit.text(text)}")` },
868868
{ level: 0, statement: `}` },
869869
]
870870
return Promise.resolve({ commands })
@@ -889,7 +889,7 @@ async function emitVerifySelectedLabel(locator: string, labelValue: string) {
889889
statement:
890890
'const selectedText = await element.findElement(By.xpath(locator)).getText()',
891891
},
892-
{ level: 1, statement: `assert(selectedText == "${labelValue}")` },
892+
{ level: 1, statement: `assert.equals(selectedText, "${labelValue}")` },
893893
{ level: 0, statement: `}` },
894894
]
895895
return Promise.resolve({
@@ -901,9 +901,9 @@ async function emitVerifyText(locator: string, text: string) {
901901
const commands = [
902902
{
903903
level: 0,
904-
statement: `assert(await driver.findElement(${await location.emit(
904+
statement: `assert.equals(await driver.findElement(${await location.emit(
905905
locator
906-
)}).getText() == "${exporter.emit.text(text)}")`,
906+
)}).getText(), "${exporter.emit.text(text)}")`,
907907
},
908908
]
909909
return Promise.resolve({ commands })
@@ -918,7 +918,7 @@ async function emitVerifyValue(locator: string, value: string) {
918918
locator
919919
)}).getAttribute("value")`,
920920
},
921-
{ level: 1, statement: `assert(value == "${value}")` },
921+
{ level: 1, statement: `assert.equals(value, "${value}")` },
922922
{ level: 0, statement: `}` },
923923
]
924924
return Promise.resolve({ commands })

0 commit comments

Comments
 (0)