remove targets from commands that dont need it

Author: corevo

packages/selenium-ide/src/neo/__test__/models/Command.spec.js

@@ -70,11 +70,18 @@ describe('Command', () => {
     expect(command.target).toBe('a')
   })
   it('should set the targets', () => {
-    const command = new Command()
+    const command = new Command(undefined, 'click')
     command.setTargets([['button', 'xpath']])
     expect(command.targets[0][0]).toBe('button')
     expect(command.targets[0][1]).toBe('xpath')
   })
+  it("should remove set targets if command doesn't support targets", () => {
+    const command = new Command(undefined, 'click')
+    command.setTargets([['button', 'xpath']])
+    expect(command.targets.length).toBe(1)
+    command.setCommand('open')
+    expect(command.targets.length).toBe(0)
+  })
   it('should set the value', () => {
     const command = new Command()
     command.setValue('123456')
@@ -177,7 +184,7 @@ describe('Command', () => {
     const jsRepresentation = {
       id: '1',
       comment: 'test',
-      command: 'open',
+      command: 'click',
       target: '/',
       targets: [['button', 'xpath']],
       value: 'test',

packages/selenium-ide/src/neo/models/Command/index.js

@@ -18,7 +18,7 @@
 import { action, computed, observable, toJS } from 'mobx'
 import uuidv4 from 'uuid/v4'
 import Fuse from 'fuse.js'
-import { Commands as _Commands } from './Commands'
+import { Commands as _Commands, TargetTypes } from './Commands'
 import { ArgTypes as _ArgTypes } from './ArgTypes'
 const EventEmitter = require('events')
 import { mergeEventEmitter } from '../../../common/events'
@@ -74,6 +74,15 @@ export default class Command {
     return Commands.array.includes(this.command)
   }
 
+  @computed
+  get canHaveTargets() {
+    if (Commands.list.has(this.command)) {
+      const { type } = Commands.list.get(this.command)
+      return type === TargetTypes.LOCATOR
+    }
+    return false
+  }
+
   @action.bound
   clone() {
     const clone = new Command()
@@ -93,6 +102,10 @@ export default class Command {
     } else {
       this.command = command || ''
     }
+
+    if (!this.canHaveTargets) {
+      this.setTargets()
+    }
   }
 
   @action.bound
@@ -102,7 +115,11 @@ export default class Command {
 
   @action.bound
   setTargets(targets = []) {
-    this.targets.replace(targets)
+    if (this.canHaveTargets) {
+      this.targets.replace(targets)
+    } else {
+      this.targets.replace([])
+    }
   }
 
   @action.bound