fix overly-persistent timeout

Author: toddtarsi

packages/selenium-ide/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@seleniumhq/selenium-ide",
-  "version": "4.0.0-alpha.3",
+  "version": "4.0.0-alpha.4",
   "private": true,
   "description": "Selenium IDE electron app",
   "author": "Todd <[email protected]>",
@@ -107,7 +107,7 @@
     "@seleniumhq/side-api": "^4.0.0-alpha.2",
     "@seleniumhq/side-model": "^4.0.0-alpha.1",
     "@seleniumhq/side-plugin-example": "^4.0.0-alpha.1",
-    "@seleniumhq/side-runtime": "^4.0.0-alpha.4",
+    "@seleniumhq/side-runtime": "^4.0.0-alpha.5",
     "electron-chromedriver": "16.0.0",
     "electron-log": "4.4.6",
     "electron-store": "^8.0.0",

packages/side-runner/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@seleniumhq/side-runner",
-  "version": "4.0.0-alpha.14",
+  "version": "4.0.0-alpha.15",
   "description": "Run Selenium IDE projects in cli",
   "repository": "https://github.com/SeleniumHQ/selenium-ide",
   "scripts": {
@@ -24,7 +24,7 @@
   "private": false,
   "dependencies": {
     "@seleniumhq/side-model": "^4.0.0-alpha.1",
-    "@seleniumhq/side-runtime": "^4.0.0-alpha.4",
+    "@seleniumhq/side-runtime": "^4.0.0-alpha.5",
     "commander": "^9.4.0",
     "glob": "^7.2.0",
     "jest": "^27.5.1",

packages/side-runtime/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@seleniumhq/side-runtime",
-  "version": "4.0.0-alpha.4",
+  "version": "4.0.0-alpha.5",
   "private": false,
   "description": "Selenium IDE playback and execution",
   "author": "Tomer <[email protected]>",

packages/side-runtime/src/playback-tree/command-node.ts

@@ -134,14 +134,17 @@ export class CommandNode {
     execute: () => Promise<unknown>,
     timeout: number
   ): Promise<unknown> {
+    const timeLimit = timeout - Date.now()
+    const expirationTimer = setTimeout(() => {
+      throw new Error('Operation timed out!')
+    }, timeLimit)
     try {
-      const timeLimit = timeout - Date.now()
-      setTimeout(() => {
-        throw new Error('Operation timed out!')
-      }, timeLimit)
-      return await execute()
+      const result = await execute()
+      clearTimeout(expirationTimer)
+      return result
     } catch (e) {
       this.handleTransientError(e, timeout)
+      clearTimeout(expirationTimer)
       return this.retryCommand(execute, timeout)
     }
   }
@@ -182,13 +185,13 @@ export class CommandNode {
     const notRetrying = Date.now() > timeout
     if (isNewErrorMessage) {
       this.transientError = thisTransientError
-      console.debug(
+      console.warn(
         'Unexpected error occured during command:',
         thisCommand,
         notRetrying ? '' : 'retrying...'
       )
       if (thisErrorMessage) {
-        console.debug(thisErrorMessage)
+        console.error(thisErrorMessage)
       }
     }