Skip to content

Commit de83a31

Browse files
committed
better quit behavior w/r/t drivers
1 parent 2f8e336 commit de83a31

File tree

3 files changed

+10
-2
lines changed

3 files changed

+10
-2
lines changed

packages/selenium-ide/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@seleniumhq/selenium-ide",
3-
"version": "4.0.0-alpha.52",
3+
"version": "4.0.0-alpha.53",
44
"private": true,
55
"description": "Selenium IDE electron app",
66
"author": "Todd <[email protected]>",

packages/selenium-ide/src/main/index.ts

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,10 @@ app.on('activate', async () => {
5959
}
6060
})
6161

62+
app.on('before-quit', async () => {
63+
await session.system.beforeQuit()
64+
})
65+
6266
app.on('window-all-closed', async () => {
6367
allWindowsClosed = true
6468
if (process.platform === 'darwin') {

packages/selenium-ide/src/main/session/controllers/System/index.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -51,9 +51,13 @@ export default class SystemController extends BaseController {
5151
throw new Error(error)
5252
}
5353

54-
async quit() {
54+
async beforeQuit() {
5555
await this.shutdown()
5656
await this.session.windows.closeAll()
57+
}
58+
59+
async quit() {
60+
this.beforeQuit()
5761
if (this.isDown) {
5862
this.session.app.quit()
5963
}

0 commit comments

Comments
 (0)