Skip to content

Commit e5e3c85

Browse files
committed
harden visible check a bit
1 parent ad953e9 commit e5e3c85

File tree

5 files changed

+12
-8
lines changed

5 files changed

+12
-8
lines changed

packages/selenium-ide/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "selenium-ide",
3-
"version": "4.0.1-alpha.93",
3+
"version": "4.0.1-alpha.94",
44
"private": false,
55
"description": "Selenium IDE electron app",
66
"author": "Todd <[email protected]>",
@@ -124,7 +124,7 @@
124124
"@seleniumhq/side-api": "^4.0.0-alpha.46",
125125
"@seleniumhq/side-commons": "^4.0.0-alpha.2",
126126
"@seleniumhq/side-model": "^4.0.0-alpha.5",
127-
"@seleniumhq/side-runtime": "^4.0.0-alpha.39",
127+
"@seleniumhq/side-runtime": "^4.0.0-alpha.40",
128128
"dnd-core": "^16.0.1",
129129
"electron-chromedriver": "^28.0.0",
130130
"electron-log": "^5.1.0",

packages/side-runner/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "selenium-side-runner",
3-
"version": "4.0.0-alpha.67",
3+
"version": "4.0.0-alpha.68",
44
"private": false,
55
"description": "Run Selenium IDE projects in cli",
66
"repository": "https://github.com/SeleniumHQ/selenium-ide",
@@ -24,7 +24,7 @@
2424
"license": "Apache-2.0",
2525
"dependencies": {
2626
"@seleniumhq/side-model": "^4.0.0-alpha.5",
27-
"@seleniumhq/side-runtime": "^4.0.0-alpha.39",
27+
"@seleniumhq/side-runtime": "^4.0.0-alpha.40",
2828
"commander": "^11.0.0",
2929
"glob": "^10.3.1",
3030
"jest": "^29.6.0",

packages/side-runtime/package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "@seleniumhq/side-runtime",
3-
"version": "4.0.0-alpha.39",
3+
"version": "4.0.0-alpha.40",
44
"private": false,
55
"description": "Selenium IDE playback and execution",
66
"author": "Tomer <[email protected]>",

packages/side-runtime/src/webdriver.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1476,7 +1476,11 @@ export default class WebDriverExecutor {
14761476
this.withCancel(async () => {
14771477
const el = await this.elementIsLocated(locator, ...fallbacks)
14781478
if (!el) return null
1479-
if (!(await el.isDisplayed())) return null
1479+
try {
1480+
if (!(await el.isDisplayed())) return null
1481+
} catch (e) {
1482+
return null
1483+
}
14801484
return el
14811485
})
14821486
)

pnpm-lock.yaml

Lines changed: 2 additions & 2 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)