[rb] restrict what tests are run when bidi enabled

titusfortner · titusfortner · commit 02a2bfcb923e · 2024-06-05T16:21:20.000-05:00
diff --git a/rb/spec/integration/selenium/webdriver/action_builder_spec.rb b/rb/spec/integration/selenium/webdriver/action_builder_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe ActionBuilder do
+    describe ActionBuilder, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       after { driver.action.clear_all_actions }
 
       describe '#send_keys' do
diff --git a/rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb b/rb/spec/integration/selenium/webdriver/bidi/browsing_context_spec.rb
@@ -22,7 +22,8 @@
 module Selenium
   module WebDriver
     class BiDi
-      describe BrowsingContext, exclusive: {bidi: true}, only: {browser: %i[chrome edge firefox]} do
+      describe BrowsingContext, exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
+                                only: {browser: %i[chrome edge firefox]} do
         after { |example| reset_driver!(example: example) }
 
         it 'can create a browsing context for given id' do
diff --git a/rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb b/rb/spec/integration/selenium/webdriver/bidi/log_inspector_spec.rb
@@ -22,7 +22,8 @@
 module Selenium
   module WebDriver
     class BiDi
-      describe LogInspector, exclusive: {bidi: true}, only: {browser: %i[chrome edge firefox]} do
+      describe LogInspector, exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
+                             only: {browser: %i[chrome edge firefox]} do
         let(:page) { 'bidi/logEntryAdded.html' }
 
         it 'can listen to console log' do
diff --git a/rb/spec/integration/selenium/webdriver/bidi/script_spec.rb b/rb/spec/integration/selenium/webdriver/bidi/script_spec.rb
@@ -21,7 +21,8 @@
 
 module Selenium
   module WebDriver
-    describe Script, exclusive: {bidi: true}, only: {browser: %i[chrome edge firefox]} do
+    describe Script, exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
+                     only: {browser: %i[chrome edge firefox]} do
       after { |example| reset_driver!(example: example) }
 
       it 'errors when bidi not enabled' do
diff --git a/rb/spec/integration/selenium/webdriver/bidi_spec.rb b/rb/spec/integration/selenium/webdriver/bidi_spec.rb
@@ -21,7 +21,8 @@
 
 module Selenium
   module WebDriver
-    describe BiDi, exclusive: {bidi: true}, only: {browser: %i[chrome edge firefox]} do
+    describe BiDi, exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
+                   only: {browser: %i[chrome edge firefox]} do
       after { |example| reset_driver!(example: example) }
 
       it 'errors when bidi not enabled' do
diff --git a/rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb b/rb/spec/integration/selenium/webdriver/chrome/driver_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Chrome
-      describe Driver, exclusive: {browser: :chrome} do
+      describe Driver, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :chrome}] do
         it 'gets and sets network conditions' do
           driver.network_conditions = {offline: false, latency: 56, throughput: 789}
           expect(driver.network_conditions).to eq(
diff --git a/rb/spec/integration/selenium/webdriver/chrome/options_spec.rb b/rb/spec/integration/selenium/webdriver/chrome/options_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Chrome
-      describe Options, exclusive: {browser: :chrome} do
+      describe Options, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :chrome}] do
         it 'passes emulated device correctly' do
           reset_driver!(emulation: {device_name: 'Nexus 5'}) do |driver|
             ua = driver.execute_script 'return window.navigator.userAgent'
diff --git a/rb/spec/integration/selenium/webdriver/chrome/profile_spec.rb b/rb/spec/integration/selenium/webdriver/chrome/profile_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Chrome
-      describe Profile, exclusive: {browser: :chrome} do
+      describe Profile, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :chrome}] do
         let(:profile) { described_class.new }
 
         it 'adds an extension' do
diff --git a/rb/spec/integration/selenium/webdriver/chrome/service_spec.rb b/rb/spec/integration/selenium/webdriver/chrome/service_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Chrome
-      describe Service, exclusive: {browser: :chrome} do
+      describe Service, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :chrome}] do
         let(:service) { described_class.new }
         let(:service_manager) { service.launch }
 
diff --git a/rb/spec/integration/selenium/webdriver/devtools_spec.rb b/rb/spec/integration/selenium/webdriver/devtools_spec.rb
@@ -21,7 +21,8 @@
 
 module Selenium
   module WebDriver
-    describe DevTools, exclusive: {browser: %i[chrome edge firefox]} do
+    describe DevTools, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'},
+                                   {browser: %i[chrome edge firefox]}] do
       after { |example| reset_driver!(example: example) }
 
       it 'sends commands' do
diff --git a/rb/spec/integration/selenium/webdriver/driver_spec.rb b/rb/spec/integration/selenium/webdriver/driver_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe Driver do
+    describe Driver, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       it_behaves_like 'driver that can be started concurrently', exclude: {browser: %i[safari safari_preview]}
 
       it 'creates default capabilities', exclude: {browser: %i[safari safari_preview]} do
diff --git a/rb/spec/integration/selenium/webdriver/edge/driver_spec.rb b/rb/spec/integration/selenium/webdriver/edge/driver_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Edge
-      describe Driver, exclusive: {browser: :edge} do
+      describe Driver, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :edge}] do
         it 'gets and sets network conditions' do
           driver.network_conditions = {offline: false, latency: 56, throughput: 789}
           expect(driver.network_conditions).to eq(
diff --git a/rb/spec/integration/selenium/webdriver/edge/options_spec.rb b/rb/spec/integration/selenium/webdriver/edge/options_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Edge
-      describe Options, exclusive: {browser: :edge} do
+      describe Options, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :edge}] do
         it 'passes emulated device correctly' do
           reset_driver!(emulation: {device_name: 'Nexus 5'}) do |driver|
             ua = driver.execute_script 'return window.navigator.userAgent'
diff --git a/rb/spec/integration/selenium/webdriver/edge/profile_spec.rb b/rb/spec/integration/selenium/webdriver/edge/profile_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Edge
-      describe Profile, exclusive: {browser: :edge} do
+      describe Profile, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :edge}] do
         let(:profile) { described_class.new }
 
         it 'adds an extension' do
diff --git a/rb/spec/integration/selenium/webdriver/edge/service_spec.rb b/rb/spec/integration/selenium/webdriver/edge/service_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Edge
-      describe Service, exclusive: {browser: :edge} do
+      describe Service, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :edge}] do
         let(:service) { described_class.new }
         let(:service_manager) { service.launch }
 
diff --git a/rb/spec/integration/selenium/webdriver/element_spec.rb b/rb/spec/integration/selenium/webdriver/element_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe Element do
+    describe Element, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       it 'clicks' do
         driver.navigate.to url_for('formPage.html')
         expect { driver.find_element(id: 'imageButton').click }.not_to raise_error
diff --git a/rb/spec/integration/selenium/webdriver/error_spec.rb b/rb/spec/integration/selenium/webdriver/error_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe Error do
+    describe Error, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       it 'raises an appropriate error' do
         driver.navigate.to url_for('xhtmlTest.html')
 
diff --git a/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb b/rb/spec/integration/selenium/webdriver/firefox/driver_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Firefox
-      describe Driver, exclusive: {browser: :firefox} do
+      describe Driver, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :firefox}] do
         let(:extensions) { '../../../../../../common/extensions/' }
 
         describe '#print_options' do
diff --git a/rb/spec/integration/selenium/webdriver/firefox/profile_spec.rb b/rb/spec/integration/selenium/webdriver/firefox/profile_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Firefox
-      describe Profile, exclusive: {browser: :firefox} do
+      describe Profile, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :firefox}] do
         let(:profile) { described_class.new }
 
         before do
diff --git a/rb/spec/integration/selenium/webdriver/firefox/service_spec.rb b/rb/spec/integration/selenium/webdriver/firefox/service_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Firefox
-      describe Service, exclusive: {browser: :firefox} do
+      describe Service, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {browser: :firefox}] do
         let(:service) { described_class.new }
         let(:service_manager) { service.launch }
 
diff --git a/rb/spec/integration/selenium/webdriver/guard_spec.rb b/rb/spec/integration/selenium/webdriver/guard_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Support
-      describe Guards, exclusive: {driver: :chrome} do
+      describe Guards, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {driver: :chrome}] do
         describe '#exclude' do
           it 'ignores an unrecognized guard parameter', invalid: {browser: :chrome} do
             # pass
diff --git a/rb/spec/integration/selenium/webdriver/listener_spec.rb b/rb/spec/integration/selenium/webdriver/listener_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe Driver do
+    describe Driver, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       before { quit_driver }
 
       it 'supports listener' do
diff --git a/rb/spec/integration/selenium/webdriver/manager_spec.rb b/rb/spec/integration/selenium/webdriver/manager_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe Manager do
+    describe Manager, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       describe 'cookie management' do
         before { driver.navigate.to url_for('xhtmlTest.html') }
 
diff --git a/rb/spec/integration/selenium/webdriver/navigation_spec.rb b/rb/spec/integration/selenium/webdriver/navigation_spec.rb
@@ -19,7 +19,7 @@
 
 require_relative 'spec_helper'
 
-describe 'Navigation' do
+describe 'Navigation', exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
   it 'navigates back and forward' do
     form_title   = 'We Leave From Here'
     result_title = 'We Arrive Here'
diff --git a/rb/spec/integration/selenium/webdriver/remote/driver_spec.rb b/rb/spec/integration/selenium/webdriver/remote/driver_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Remote
-      describe Driver, exclusive: {driver: :remote} do
+      describe Driver, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'}, {driver: :remote}] do
         it 'exposes session_id' do
           expect(driver.session_id).to be_a(String)
         end
diff --git a/rb/spec/integration/selenium/webdriver/remote/element_spec.rb b/rb/spec/integration/selenium/webdriver/remote/element_spec.rb
@@ -21,14 +21,12 @@
 
 module Selenium
   module WebDriver
-    describe Element do
+    describe Element, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       before do
         driver.file_detector = ->(filename) { File.join(__dir__, filename) }
       end
 
-      after do
-        driver.file_detector = nil
-      end
+      after { driver.file_detector = nil }
 
       context 'when uploading one file' do
         it 'uses the provided file detector', exclusive: {driver: :remote},
diff --git a/rb/spec/integration/selenium/webdriver/safari/driver_spec.rb b/rb/spec/integration/selenium/webdriver/safari/driver_spec.rb
@@ -22,7 +22,8 @@
 module Selenium
   module WebDriver
     module Safari
-      describe Driver, exclusive: {browser: %i[safari safari_preview]} do
+      describe Driver, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'},
+                                   {browser: %i[safari safari_preview]}] do
         it 'gets and sets permissions' do
           driver.permissions = {'getUserMedia' => false}
           expect(driver.permissions).to eq('getUserMedia' => false)
diff --git a/rb/spec/integration/selenium/webdriver/select_spec.rb b/rb/spec/integration/selenium/webdriver/select_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module Support
-      describe Select do
+      describe Select, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
         let(:select) { described_class.new(driver.find_element(name: 'selectomatic')) }
         let(:multi_select) { described_class.new(driver.find_element(id: 'multi')) }
         let(:single_disabled) { described_class.new(driver.find_element(name: 'single_disabled')) }
diff --git a/rb/spec/integration/selenium/webdriver/shadow_root_spec.rb b/rb/spec/integration/selenium/webdriver/shadow_root_spec.rb
@@ -21,7 +21,8 @@
 
 module Selenium
   module WebDriver
-    describe ShadowRoot, only: {browser: %i[chrome firefox edge safari]} do
+    describe ShadowRoot, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'},
+                                     {browser: %i[chrome firefox edge safari]}] do
       before { driver.navigate.to url_for('webComponents.html') }
 
       let(:custom_element) { driver.find_element(css: 'custom-checkbox-element') }
diff --git a/rb/spec/integration/selenium/webdriver/storage_spec.rb b/rb/spec/integration/selenium/webdriver/storage_spec.rb
@@ -22,7 +22,7 @@
 module Selenium
   module WebDriver
     module DriverExtensions
-      describe HasWebStorage do
+      describe HasWebStorage, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
         shared_examples 'web storage' do
           before do
             driver.navigate.to url_for('clicks.html')
diff --git a/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb b/rb/spec/integration/selenium/webdriver/takes_screenshot_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe TakesScreenshot do
+    describe TakesScreenshot, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       before do
         driver.navigate.to url_for('xhtmlTest.html')
       end
@@ -80,9 +80,7 @@ def save_screenshot_and_assert(source, path)
           driver.navigate.to url_for('printPage.html')
         end
 
-        after do
-          FileUtils.rm_rf(path)
-        end
+        after { FileUtils.rm_rf(path) }
 
         it 'takes viewport screenshot by default' do
           viewport_width = driver.execute_script('return window.innerWidth;')
diff --git a/rb/spec/integration/selenium/webdriver/target_locator_spec.rb b/rb/spec/integration/selenium/webdriver/target_locator_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe TargetLocator do
+    describe TargetLocator, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       before { @original_window = driver.window_handle }
 
       after do
@@ -325,7 +325,7 @@ module WebDriver
         end
 
         describe 'unhandled alert error' do
-          after { reset_driver! }
+          after { |example| reset_driver!(example: example) }
 
           it 'raises an UnexpectedAlertOpenError if an alert has not been dealt with' do
             driver.navigate.to url_for('alerts.html')
diff --git a/rb/spec/integration/selenium/webdriver/timeout_spec.rb b/rb/spec/integration/selenium/webdriver/timeout_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe Timeouts do
+    describe Timeouts, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       before do
         driver.manage.timeouts.implicit_wait = 6
         driver.manage.timeouts.page_load = 2
diff --git a/rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb b/rb/spec/integration/selenium/webdriver/virtual_authenticator_spec.rb
@@ -21,7 +21,8 @@
 
 module Selenium
   module WebDriver
-    describe VirtualAuthenticator, exclusive: {browser: %i[chrome edge]} do
+    describe VirtualAuthenticator, exclusive: [{bidi: false, reason: 'Not yet implemented with BiDi'},
+                                               {browser: %i[chrome edge]}] do
       # A pkcs#8 encoded unencrypted EC256 private key as a base64url string.
       let(:pkcs8_private_key) do
         'MIGHAgEAMBMGByqGSM49AgEGCCqGSM49AwEHBG0wawIBAQQg8_zMDQDYAxlU-Q' \
diff --git a/rb/spec/integration/selenium/webdriver/window_spec.rb b/rb/spec/integration/selenium/webdriver/window_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe Window do
+    describe Window, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       after(:all) { reset_driver! }
 
       let(:window) { driver.manage.window }
diff --git a/rb/spec/integration/selenium/webdriver/zipper_spec.rb b/rb/spec/integration/selenium/webdriver/zipper_spec.rb
@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    describe Zipper do
+    describe Zipper, exclusive: {bidi: false, reason: 'Not yet implemented with BiDi'} do
       let(:base_file_name) { 'file.txt' }
       let(:file_content)   { 'content' }
       let(:zip_file)       { File.join(Dir.tmpdir, 'test.zip') }
@@ -34,9 +34,7 @@ def create_file
         filename
       end
 
-      after do
-        FileUtils.rm_rf zip_file
-      end
+      after { FileUtils.rm_rf zip_file }
 
       describe '#zip' do
         it 'a file' do
