Skip to content

Commit 02ace40

Browse files
Merge branch 'trunk' into local-value
2 parents a762425 + b9fda18 commit 02ace40

File tree

89 files changed

+1602
-971
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

89 files changed

+1602
-971
lines changed

.github/workflows/pre-release.yml

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -97,17 +97,19 @@ jobs:
9797
**Warning: Manually update the changelogs before merging**
9898
9999
This PR:
100-
* Updates Rust version for Selenium Manager release
101100
* Updates Pinned browser version to coincide with new CDP release
102101
* Adds support for new CDP version and removes old CDP version
103102
* Selenium Manager references the new Selenium Manager release
104103
* Updates Maven Dependencies
105104
* Adds new authors to authors file
106105
* Updates all versions for all bindings
107106
* Generates *rough* change logs for each bindings (please tidy them up before merging this)
107+
* Not all commits need to be in the change log — users do not need to see anything about building or testing Selenium
108+
* Remove references to updating versions including nightly
109+
* The code now outputs the complete body of the commit message; make sure the changelog message is complete and correct
108110
109-
- Auto-generated by [create-pull-request][1]
111+
- This PR was auto-generated by workflow run: [release-preparation][1]
110112
111-
[1]: https://github.com/peter-evans/create-pull-request
113+
[1]: https://github.com/SeleniumHQ/selenium/actions/runs/${{ github.run_id }}
112114
labels: C-build
113115
draft: true

.github/workflows/update-documentation.yml

Lines changed: 37 additions & 175 deletions
Original file line numberDiff line numberDiff line change
@@ -3,227 +3,89 @@ name: Update Documentation
33
on:
44
workflow_dispatch:
55
inputs:
6-
tag:
7-
description: Release tag (e.g. selenium-4.21.0)
6+
version:
7+
description: Release version (e.g., 4.21.0)
88
required: true
99
type: string
10+
language:
11+
description: language documentation
12+
required: true
13+
type: choice
14+
default: "all"
15+
options:
16+
- java
17+
- rb
18+
- py
19+
- dotnet
20+
- node
21+
- all
1022

1123
workflow_call:
1224
inputs:
13-
tag:
25+
version:
26+
required: true
27+
type: string
28+
sha:
1429
required: true
1530
type: string
31+
language:
32+
required: false
33+
type: string
34+
default: "all"
1635

1736
env:
1837
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
1938

2039
jobs:
21-
determine-language:
22-
runs-on: ubuntu-latest
23-
outputs:
24-
language: ${{ steps.get-language.outputs.language }}
25-
steps:
26-
- name: Parse language from tag
27-
id: get-language
28-
run: |
29-
tag=${{ inputs.tag }}
30-
language=$(echo $tag | awk -F'-' '{print $NF}')
31-
if [[ ! "$language" =~ ^(java|ruby|python|dotnet|node)$ ]]; then
32-
language="all"
33-
fi
34-
echo "language=$language" > $GITHUB_OUTPUT
35-
36-
java-docs:
37-
runs-on: ubuntu-latest
38-
needs: determine-language
39-
steps:
40-
- name: Checkout the tag
41-
uses: actions/checkout@v4
42-
with:
43-
ref: ${{ inputs.tag }}
44-
- name: Prep git
45-
run: |
46-
git config --local user.email "[email protected]"
47-
git config --local user.name "Selenium CI Bot"
48-
- name: Setup Java
49-
uses: actions/setup-java@v4
50-
with:
51-
java-version: 17
52-
distribution: 'temurin'
53-
- name: Update Documentation
54-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'java'
55-
run: ./go java:docs
56-
- name: Create patch for changes
57-
run: |
58-
git format-patch -1 HEAD --stdout > java-docs.patch
59-
- name: Upload patch
60-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'java'
61-
uses: actions/upload-artifact@v4
62-
with:
63-
name: java-docs-patch
64-
path: java-docs.patch
65-
66-
ruby-docs:
40+
build-docs:
6741
runs-on: ubuntu-latest
68-
needs: determine-language
6942
steps:
70-
- name: Checkout the tag
43+
- name: Checkout repository
7144
uses: actions/checkout@v4
7245
with:
73-
ref: ${{ inputs.tag }}
74-
- name: Prep git
46+
ref: ${{ github.event_name == 'workflow_dispatch' && github.ref || inputs.sha }}
47+
- name: Fetch gh-pages branch
48+
run: git fetch origin gh-pages
49+
- name: Setup git
7550
run: |
7651
git config --local user.email "[email protected]"
7752
git config --local user.name "Selenium CI Bot"
53+
- name: Setup curl for Ubuntu
54+
run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev
7855
- name: Setup Java
7956
uses: actions/setup-java@v4
8057
with:
8158
java-version: 17
8259
distribution: 'temurin'
83-
- name: Setup curl for Ubuntu
84-
run: sudo apt-get update && sudo apt-get install -y libcurl4-openssl-dev
85-
- name: Update Documentation
86-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'ruby'
87-
run: ./go rb:docs
88-
- name: Create patch for changes
89-
run: |
90-
git format-patch -1 HEAD --stdout > ruby-docs.patch
91-
- name: Upload patch
92-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'ruby'
93-
uses: actions/upload-artifact@v4
94-
with:
95-
name: ruby-docs-patch
96-
path: ruby-docs.patch
97-
98-
python-docs:
99-
needs: determine-language
100-
runs-on: ubuntu-latest
101-
steps:
102-
- name: Checkout the tag
103-
uses: actions/checkout@v4
104-
with:
105-
ref: ${{ inputs.tag }}
106-
- name: Prep git
107-
run: |
108-
git config --local user.email "[email protected]"
109-
git config --local user.name "Selenium CI Bot"
11060
- name: Set up Python 3.9
61+
if: ${{ inputs.language == 'all' || inputs.language == 'py' }}
11162
uses: actions/setup-python@v5
11263
with:
11364
python-version: 3.9
11465
- name: Install dependencies
66+
if: ${{ inputs.language == 'all' || inputs.language == 'py' }}
11567
run: |
11668
python -m pip install --upgrade pip
11769
pip install tox
118-
- name: Update Documentation
119-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'python'
120-
run: ./go py:docs
121-
- name: Create patch for changes
122-
run: |
123-
git format-patch -1 HEAD --stdout > python-docs.patch
124-
- name: Upload patch
125-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'python'
126-
uses: actions/upload-artifact@v4
127-
with:
128-
name: python-docs-patch
129-
path: python-docs.patch
130-
131-
dotnet-docs:
132-
needs: determine-language
133-
runs-on: ubuntu-latest
134-
steps:
135-
- name: Checkout the tag
136-
uses: actions/checkout@v4
137-
with:
138-
ref: ${{ inputs.tag }}
139-
- name: Prep git
140-
run: |
141-
git config --local user.email "[email protected]"
142-
git config --local user.name "Selenium CI Bot"
143-
- name: Update Documentation
144-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'dotnet'
145-
run: ./go dotnet:docs
146-
- name: Create patch for changes
147-
run: |
148-
git format-patch -1 HEAD --stdout > dotnet-docs.patch
149-
- name: Upload patch
150-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'dotnet'
151-
uses: actions/upload-artifact@v4
152-
with:
153-
name: dotnet-docs-patch
154-
path: dotnet-docs.patch
155-
156-
node-docs:
157-
needs: determine-language
158-
runs-on: ubuntu-latest
159-
steps:
160-
- name: Checkout the tag
161-
uses: actions/checkout@v4
162-
with:
163-
ref: ${{ inputs.tag }}
164-
- name: Prep git
165-
run: |
166-
git config --local user.email "[email protected]"
167-
git config --local user.name "Selenium CI Bot"
16870
- name: Install npm dependencies
71+
if: ${{ inputs.language == 'all' || inputs.language == 'node' }}
16972
run: |
17073
npm install
17174
npm install --prefix javascript/node/selenium-webdriver
17275
- name: Update Documentation
173-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'node'
174-
run: ./go node:docs
175-
- name: Create patch for changes
176-
run: |
177-
git format-patch -1 HEAD --stdout > node-docs.patch
178-
- name: Upload patch
179-
if: needs.determine-language.outputs.language == 'all' || needs.determine-language.outputs.language == 'node'
180-
uses: actions/upload-artifact@v4
181-
with:
182-
name: node-docs-patch
183-
path: node-docs.patch
76+
run: ./go ${{ inputs.language }}:docs
18477

185-
merge-patches:
186-
runs-on: ubuntu-latest
187-
needs: [java-docs, ruby-docs, python-docs, dotnet-docs, node-docs]
188-
steps:
189-
- name: Checkout documentation branch
190-
uses: actions/checkout@v4
191-
with:
192-
ref: 'gh-pages'
193-
fetch-depth: 0
194-
fetch-tags: true
195-
- name: Create and checkout new branch
196-
run: |
197-
git config --local user.email "[email protected]"
198-
git config --local user.name "Selenium CI Bot"
199-
git checkout -b api-docs-${{ inputs.tag }}
200-
- name: Download all patches
201-
uses: actions/download-artifact@v4
202-
with:
203-
path: patches/
204-
merge-multiple: true
205-
- name: Show downloaded patches
206-
run: ls -lah patches/
207-
- name: Apply patches
208-
run: |
209-
for patch in patches/*.patch; do
210-
git am < "$patch"
211-
done
212-
rm -rf patches/
213-
- name: Push Branch
214-
run: git push origin api-docs-${{ inputs.tag }}
21578
- name: Documentation Pull Request
21679
uses: peter-evans/create-pull-request@v6
21780
with:
21881
token: ${{ secrets.SELENIUM_CI_TOKEN }}
21982
author: Selenium CI Bot <[email protected]>
22083
delete-branch: true
221-
branch: api-docs-${{ inputs.tag }}
84+
branch: api-docs-${{ inputs.version }}-${{ inputs.language }}
22285
base: gh-pages
223-
title: Update documentation for ${{ inputs.tag }}
86+
title: Update documentation for Selenium ${{ inputs.version }} (${{ inputs.language }})
22487
body: |
225-
This PR updates the API documentation for all bindings
226-
based on the provided tag name.
88+
This PR updates the API documentation for **${{ inputs.language }}** language bindings to version **${{ inputs.version }}**.
22789
22890
- Auto-generated by [create-pull-request][1]
22991

AUTHORS

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -11,6 +11,7 @@ abidema <[email protected]>
1111
Adam Dangoor <[email protected]>
1212
Adam Demuri <[email protected]>
1313
Adam Goucher <[email protected]>
14+
Adam Halbrock <[email protected]>
1415
Adam Smith <[email protected]>
1516
AdamPDotty <[email protected]>
1617
Adi Roiban <[email protected]>
@@ -282,6 +283,7 @@ EwaMarek <[email protected]>
282283
283284
Felipe Knorr Kuhn <[email protected]>
284285
Fenil Mehta <[email protected]>
286+
FloKNetcare <[email protected]>
285287
Florian Apolloner <[email protected]>
286288
Florian LOPES <[email protected]>
287289
Florian Mutter <[email protected]>
@@ -454,6 +456,7 @@ John J. Barton <[email protected]>
454456
John Pelly <[email protected]>
455457
456458
459+
Jolyon Pawlyn <[email protected]>
457460
458461
Jon Dufresne <[email protected]>
459462
Jon Spalding
@@ -685,6 +688,7 @@ orangeudav <[email protected]>
685688
Oscar Devora <[email protected]>
686689
687690
Paladin Wang <[email protected]>
691+
688692
Palmer Bandy <[email protected]>
689693
Pat Tullmann <[email protected]>
690694
Patrice Jaton <[email protected]>
@@ -744,6 +748,7 @@ Robert Fletcher <[email protected]>
744748
Roberto Rivera <[email protected]>
745749
Robin Stocker <[email protected]>
746750
Rod McNew <[email protected]>
751+
Romain Tartière <[email protected]>
747752
Roman Yurchak <[email protected]>
748753
Roman Yurchak <[email protected]>
749754
Roman Zoller <[email protected]>

MODULE.bazel

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,7 @@ maven.install(
176176
"com.github.stephenc.jcip:jcip-annotations:1.0-1",
177177
"com.google.code.findbugs:jsr305:3.0.2",
178178
"com.google.code.gson:gson:2.12.1",
179-
"com.google.guava:guava:33.4.0-jre",
179+
"com.google.guava:guava:33.4.5-jre",
180180
"com.google.auto:auto-common:1.2.2",
181181
"com.google.auto.service:auto-service:1.1.1",
182182
"com.google.auto.service:auto-service-annotations:1.1.1",
@@ -219,7 +219,7 @@ maven.install(
219219
"org.junit.platform:junit-platform-commons:1.12.1",
220220
"org.junit.platform:junit-platform-engine:1.12.1",
221221
"org.mockito:mockito-core:5.16.1",
222-
"org.redisson:redisson:3.45.0",
222+
"org.redisson:redisson:3.45.1",
223223
"org.slf4j:slf4j-api:2.0.17",
224224
"org.slf4j:slf4j-jdk14:2.0.17",
225225
"org.tomlj:tomlj:1.1.1",

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ for Maven to use locally by deploying to your local maven repository (`~/.m2/rep
201201

202202
#### Updating Dependencies
203203

204-
Dependencies are defined in the file [maven_deps.bzl](https://github.com/SeleniumHQ/selenium/blob/trunk/java/maven_deps.bzl).
204+
Dependencies are defined in the file [MODULE.bazel](https://github.com/SeleniumHQ/selenium/blob/trunk/MODULE.bazel).
205205
To automatically update and pin new dependencies, run:
206206

207207
```shell

0 commit comments

Comments
 (0)