[py] Remove old linters and add ruff

Author: cgoldberg

.github/workflows/ci-python.yml

@@ -51,9 +51,7 @@ jobs:
       - name: Test with tox
         run: tox -c py/tox.ini
         env:
-          # If this fails, it will exit. Local work should be using `tox -e linting` prior to committing.
-          # the linting-ci recipe exists solely for CI and will not attempt to rewrite any files in-place etc.
-          TOXENV: linting-ci
+          TOXENV: linting
 
   mypy:
     name: Mypy

py/pyproject.toml

@@ -131,53 +131,28 @@ ignore_missing_imports = true
 # suppress error messages about imports that cannot be resolved.
 ignore_missing_imports = true
 
-[tool.isort]
-# isort is a common python tool for keeping imports nicely formatted.
-# Automatically keep imports alphabetically sorted, on single lines in
-# PEP recommended sections (https://peps.python.org/pep-0008/#imports)
-# files or individual lines can be ignored via `# isort:skip|# isort:skip_file`.
-force_single_line = true
-profile = "black"
-py_version = 39
-quiet = true
-skip = "selenium/webdriver/common/devtools"
-
-[tool.black]
-extend-exclude = "selenium/webdriver/common/devtools"
-line-length = 120
-target-version = ["py39"]
-
-[tool.autoflake]
+[tool.docformatter]
 exclude = "selenium/webdriver/common/devtools"
-ignore-pass-after-docstring = true
 in-place = true
-quiet = true
 recursive = true
-remove-all-unused-imports = true
-remove-duplicate-keys = true
-remove-unused-variables = true
-
-[tool.flake8]
-exclude = "selenium/webdriver/common/devtools"
-# Disable E501 once line length is better handled
-extend-ignore = ["E501", "E203"]
-# This does nothing for now as E501 is ignored
-max-line-length = 120
-min-python-version = "3.9"
 
 [tool.ruff]
-exclude = [
+extend-exclude = [
     "selenium/webdriver/common/devtools/",
     "private/",
     "generate.py",
 ]
 line-length = 120
+indent-width = 4
+respect-gitignore = true
+target-version = "py39"
 
 [tool.ruff.lint]
-extend-select = ["E501"]
+#extend-select = ["E4", "E7", "E9", "F"]
+extend-select = ["E4", "E7", "E9", "F", "E501"]
+#extend-ignore = ["E501"]
 fixable = ["ALL"]
 
-[tool.docformatter]
-exclude = "selenium/webdriver/common/devtools"
-in-place = true
-recursive = true
+[tool.ruff.format]
+docstring-code-format = true
+docstring-code-line-length = 120

py/tox.ini

@@ -32,46 +32,12 @@ deps =
   trio-typing==0.10.0
 commands = mypy --install-types {posargs}
 
-[testenv:linting-ci]
-; checks linting for CI with stricter exiting when failing and no rewriting
-skip_install = true
-deps =
-  isort==6.0.1
-  black==25.1.0
-  autoflake==2.3.1
-  flake8==7.1.2
-  flake8-pyproject==1.2.3
-  flake8-typing-imports==1.16.0
-  docformatter==1.7.5
-commands =
-  isort --check-only --diff selenium/ test/ conftest.py
-  black --check --diff selenium/ test/ conftest.py
-  autoflake --check-diff selenium/ test/ conftest.py
-  flake8 selenium/ test/ conftest.py
-  docformatter --check --diff selenium/ test/ conftest.py
-
 [testenv:linting]
-; A consolidated linting based recipe, responsible for executing linting tools across the code base.
-; This encompasses:
-;   - isort for imports
-;   - black and flake8 for general formatting
-;   - autoflake for unused imports and variables
-;   - docformatter for docstrings
-; IMPORTANT:
-;   - isort, black, autoflake, docformatter: will rewrite files
-;   - flake8: only alerts to the failures
 skip_install = true
 deps =
-  isort==6.0.1
-  black==25.1.0
-  autoflake==2.3.1
-  flake8==7.1.2
-  flake8-pyproject==1.2.3
-  flake8-typing-imports==1.16.0
+  ruff==0.11.10
   docformatter==1.7.5
 commands =
-  isort selenium/ test/ conftest.py
-  black selenium/ test/ conftest.py
-  autoflake selenium/ test/ conftest.py
-  flake8 selenium/ test/ conftest.py
   docformatter selenium/ test/ conftest.py
+  ruff check --fix --show-fixes --exit-non-zero-on-fix selenium/ test/ conftest.py
+  ruff format --exit-non-zero-on-format selenium/ test/ conftest.py