Marking elements with 'pointer-events' style of 'none' as obscured in IE

Author: jimevans

cpp/iedriver/Element.cpp

@@ -246,11 +246,36 @@ bool Element::IsObscured(LocationInfo* click_location,
     return false;
   }
 
-  bool is_obscured = false;
 
   CComPtr<IHTMLDocument2> doc;
   this->GetContainingDocument(false, &doc);
 
+  // If an element has a style value where pointer-events is set to 'none',
+  // the element is "obscured" by definition.
+  CComPtr<IHTMLWindow2> window;
+  hr = doc->get_parentWindow(&window);
+  if (SUCCEEDED(hr) && window) {
+    CComPtr<IHTMLWindow7> window7;
+    hr = window->QueryInterface<IHTMLWindow7>(&window7);
+    if (SUCCEEDED(hr) && window7) {
+      CComPtr<IHTMLDOMNode> node;
+      hr = this->element_->QueryInterface<IHTMLDOMNode>(&node);
+      if (SUCCEEDED(hr) && node) {
+        CComPtr<IHTMLCSSStyleDeclaration> computed_style;
+        hr = window7->getComputedStyle(node, L"", &computed_style);
+        if (SUCCEEDED(hr) && computed_style) {
+          CComBSTR pointer_events_value = L"";
+          hr = computed_style->get_pointerEvents(&pointer_events_value);
+          if (SUCCEEDED(hr) && pointer_events_value == L"none") {
+            return true;
+          }
+        }
+      }
+    }
+  }
+
+  bool is_obscured = false;
+
   std::vector<LocationInfo> frame_locations;
   LocationInfo element_location = {};
   int status_code = this->GetLocation(&element_location, &frame_locations);
@@ -588,7 +613,7 @@ int Element::GetLocationOnceScrolledIntoView(const ElementScrollBehavior scroll,
 bool Element::IsHiddenByOverflow() {
   LOG(TRACE) << "Entering Element::IsHiddenByOverflow";
 
-  bool isOverflow = false;
+  bool is_overflow = false;
 
   std::wstring script_source(L"(function() { return (");
   script_source += atoms::asString(atoms::IS_IN_PARENT_OVERFLOW);
@@ -602,12 +627,12 @@ bool Element::IsHiddenByOverflow() {
   if (status_code == WD_SUCCESS) {
     std::wstring raw_overflow_state(script_wrapper.result().bstrVal);
     std::string overflow_state = StringUtilities::ToString(raw_overflow_state);
-    isOverflow = (overflow_state == "scroll");
+    is_overflow = (overflow_state == "scroll");
   } else {
     LOG(WARN) << "Unable to determine is element hidden by overflow";
   }
 
-  return isOverflow;
+  return is_overflow;
 }
 
 bool Element::IsLocationVisibleInFrames(const LocationInfo location,

cpp/iedriverserver/CHANGELOG

@@ -9,6 +9,12 @@ available via the project downloads page. Changes in "revision" field indicate
 private releases checked into the prebuilts directory of the source tree, but
 not made generally available on the downloads page.
 
+v3.12.0.5
+=========
+ * Updating to indicate elements with 'pointer-events' style of 'none' as
+   obscured, triggering "element click intercepted" error response. This is
+   in keeping with the W3C WebDriver Specification that demands this behavior.
+
 v3.12.0.4
 =========
  * Updates to JavaScript automation atoms.

cpp/iedriverserver/IEDriverServer.rc

@@ -50,8 +50,8 @@ END
 //
 
 VS_VERSION_INFO VERSIONINFO
- FILEVERSION 3,12,0,4
- PRODUCTVERSION 3,12,0,4
+ FILEVERSION 3,12,0,5
+ PRODUCTVERSION 3,12,0,5
  FILEFLAGSMASK 0x3fL
 #ifdef _DEBUG
  FILEFLAGS 0x1L
@@ -68,12 +68,12 @@ BEGIN
         BEGIN
             VALUE "CompanyName", "Software Freedom Conservancy"
             VALUE "FileDescription", "Command line server for the IE driver"
-            VALUE "FileVersion", "3.12.0.4"
+            VALUE "FileVersion", "3.12.0.5"
             VALUE "InternalName", "IEDriverServer.exe"
             VALUE "LegalCopyright", "Copyright (C) 2017"
             VALUE "OriginalFilename", "IEDriverServer.exe"
             VALUE "ProductName", "Selenium WebDriver"
-            VALUE "ProductVersion", "3.12.0.4"
+            VALUE "ProductVersion", "3.12.0.5"
         END
     END
     BLOCK "VarFileInfo"