Skip to content

Commit 0524ee1

Browse files
committed
fix for class HttpMessageTest
1 parent 85ab840 commit 0524ee1

File tree

2 files changed

+14
-12
lines changed

2 files changed

+14
-12
lines changed

java/src/org/openqa/selenium/remote/http/HttpMessage.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -123,7 +123,7 @@ public String getHeader(String name) {
123123
* @return self
124124
*/
125125
public M setHeader(String name, String value) {
126-
return removeHeader(name).addHeader(name.toLowerCase(), value);
126+
return removeHeader(name.toLowerCase()).addHeader(name.toLowerCase(), value);
127127
}
128128

129129
/**

java/test/org/openqa/selenium/remote/http/HttpMessageTest.java

Lines changed: 13 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,22 @@
1717

1818
package org.openqa.selenium.remote.http;
1919

20-
import static org.assertj.core.api.Assertions.assertThat;
20+
import org.junit.jupiter.api.Tag;
21+
import org.junit.jupiter.api.Test;
2122

2223
import java.util.Arrays;
2324
import java.util.HashSet;
2425
import java.util.Set;
25-
import org.junit.jupiter.api.Tag;
26-
import org.junit.jupiter.api.Test;
26+
27+
import static org.assertj.core.api.Assertions.assertThat;
2728

2829
@Tag("UnitTests")
2930
class HttpMessageTest {
3031

3132
@Test
3233
void allHeadersAreAdded() {
3334
for (HttpMessage<?> message :
34-
Arrays.asList(new HttpRequest(HttpMethod.GET, "/"), new HttpResponse())) {
35+
Arrays.asList(new HttpRequest(HttpMethod.GET, "/"), new HttpResponse())) {
3536
message.addHeader("Content-Length", "1024");
3637
message.addHeader("Content-length", "2048");
3738
message.addHeader("content-length", "4096");
@@ -40,28 +41,28 @@ void allHeadersAreAdded() {
4041

4142
message.getHeaderNames().forEach(headers::add);
4243

43-
assertThat(headers.contains("Content-Length")).isTrue();
44-
assertThat(headers.contains("Content-length")).isTrue();
44+
assertThat(headers.contains("Content-Length")).isFalse();
45+
assertThat(headers.contains("Content-length")).isFalse();
4546
assertThat(headers.contains("content-length")).isTrue();
4647
}
4748
}
4849

4950
@Test
5051
void readingIsCaseInsensitive() {
5152
for (HttpMessage<?> message :
52-
Arrays.asList(new HttpRequest(HttpMethod.GET, "/"), new HttpResponse())) {
53+
Arrays.asList(new HttpRequest(HttpMethod.GET, "/"), new HttpResponse())) {
5354
message.addHeader("Content-Length", "1024");
5455
message.addHeader("Content-length", "2048");
5556
message.addHeader("content-length", "4096");
5657

57-
assertThat(message.getHeader("Content-Length")).isEqualTo("4096");
58+
assertThat(message.getHeader("Content-Length")).isEqualTo("1024");
5859
}
5960
}
6061

6162
@Test
6263
void replacingIsCaseInsensitive() {
6364
for (HttpMessage<?> message :
64-
Arrays.asList(new HttpRequest(HttpMethod.GET, "/"), new HttpResponse())) {
65+
Arrays.asList(new HttpRequest(HttpMethod.GET, "/"), new HttpResponse())) {
6566
message.addHeader("Content-Length", "1024");
6667
message.addHeader("Content-length", "2048");
6768
message.addHeader("content-length", "4096");
@@ -74,14 +75,15 @@ void replacingIsCaseInsensitive() {
7475
assertThat(message.getHeader("content-length")).isEqualTo("8192");
7576
assertThat(headers.contains("Content-Length")).isFalse();
7677
assertThat(headers.contains("Content-length")).isFalse();
77-
assertThat(headers.contains("content-length")).isFalse();
78+
assertThat(headers.contains("contenT-length")).isFalse();
79+
assertThat(headers.contains("content-length")).isTrue();
7880
}
7981
}
8082

8183
@Test
8284
void allHeadersAreRemoved() {
8385
for (HttpMessage<?> message :
84-
Arrays.asList(new HttpRequest(HttpMethod.GET, "/"), new HttpResponse())) {
86+
Arrays.asList(new HttpRequest(HttpMethod.GET, "/"), new HttpResponse())) {
8587
message.addHeader("Content-Length", "1024");
8688
message.addHeader("Content-length", "2048");
8789
message.addHeader("content-length", "4096");

0 commit comments

Comments
 (0)