Fix spotbugs tests

Author: shs96c

java/BUILD.bazel

@@ -38,7 +38,6 @@ java_library(
 
 spotbugs_config(
     name = "spotbugs-config",
-    effort = "default",
     exclude_filter = "spotbugs-excludes.xml",
     fail_on_warning = True,
     visibility = [

java/spotbugs-excludes.xml

@@ -20,6 +20,11 @@
     <Bug code="RCN,MS,DCN,UwF,THROWS,SSD"/>
   </Match>
 
+  <Match>
+    <!-- Warnings about finalizer attacks are really not worth addressing -->
+    <Bug code="CT"/>
+  </Match>
+
   <Match>
     <Class name="~.*\.*Test"/>
   </Match>
@@ -139,7 +144,7 @@
     <Class name="org.openqa.selenium.json.JsonInputIterator"/>
     <Bug pattern="IT_NO_SUCH_ELEMENT"/>
   </Match>
-  
+
   <Match>
     <Class name="org.openqa.selenium.net.NetworkUtils"/>
     <Bug pattern="ST_WRITE_TO_STATIC_FROM_INSTANCE_METHOD"/>

java/src/org/openqa/selenium/chrome/ChromeDriver.java

@@ -85,9 +85,12 @@ public ChromeDriver(ChromeDriverService service, ChromeOptions options) {
 
   public ChromeDriver(
       ChromeDriverService service, ChromeOptions options, ClientConfig clientConfig) {
-    super(generateExecutor(service, options, clientConfig), options, ChromeOptions.CAPABILITY);
-    casting = new AddHasCasting().getImplementation(getCapabilities(), getExecuteMethod());
-    cdp = new AddHasCdp().getImplementation(getCapabilities(), getExecuteMethod());
+    super(
+      generateExecutor(service, options, clientConfig),
+      options,
+      ChromeOptions.CAPABILITY,
+      (caps, method) -> new AddHasCasting().getImplementation(caps, method),
+      (caps, method) -> new AddHasCdp().getImplementation(caps, method));
   }
 
   private static ChromeDriverCommandExecutor generateExecutor(

java/src/org/openqa/selenium/chromium/ChromiumDriver.java

@@ -28,6 +28,7 @@
 import java.util.Map;
 import java.util.Optional;
 import java.util.Set;
+import java.util.function.BiFunction;
 import java.util.function.Predicate;
 import java.util.function.Supplier;
 import java.util.logging.Level;
@@ -62,6 +63,7 @@
 import org.openqa.selenium.logging.EventType;
 import org.openqa.selenium.logging.HasLogEvents;
 import org.openqa.selenium.remote.CommandExecutor;
+import org.openqa.selenium.remote.ExecuteMethod;
 import org.openqa.selenium.remote.FileDetector;
 import org.openqa.selenium.remote.RemoteWebDriver;
 import org.openqa.selenium.remote.html5.RemoteLocationContext;
@@ -106,14 +108,20 @@ public class ChromiumDriver extends RemoteWebDriver
   private final Map<Integer, ScriptKey> scriptKeys = new HashMap<>();
 
   protected ChromiumDriver(
-      CommandExecutor commandExecutor, Capabilities capabilities, String capabilityKey) {
+    CommandExecutor commandExecutor,
+    Capabilities capabilities,
+    String capabilityKey,
+    BiFunction<Capabilities, ExecuteMethod, HasCasting> createCasting,
+    BiFunction<Capabilities, ExecuteMethod, HasCdp> createCdp) {
     super(commandExecutor, capabilities);
     locationContext = new RemoteLocationContext(getExecuteMethod());
     webStorage = new RemoteWebStorage(getExecuteMethod());
     permissions = new AddHasPermissions().getImplementation(getCapabilities(), getExecuteMethod());
     networkConditions =
         new AddHasNetworkConditions().getImplementation(getCapabilities(), getExecuteMethod());
     launch = new AddHasLaunchApp().getImplementation(getCapabilities(), getExecuteMethod());
+    casting = createCasting.apply(getCapabilities(), getExecuteMethod());
+    cdp = createCdp.apply(getCapabilities(), getExecuteMethod());
 
     HttpClient.Factory factory = HttpClient.Factory.createDefault();
     Capabilities originalCapabilities = super.getCapabilities();

java/src/org/openqa/selenium/edge/EdgeDriver.java

@@ -57,9 +57,12 @@ public EdgeDriver(EdgeDriverService service, EdgeOptions options) {
   }
 
   public EdgeDriver(EdgeDriverService service, EdgeOptions options, ClientConfig clientConfig) {
-    super(generateExecutor(service, options, clientConfig), options, EdgeOptions.CAPABILITY);
-    casting = new AddHasCasting().getImplementation(getCapabilities(), getExecuteMethod());
-    cdp = new AddHasCdp().getImplementation(getCapabilities(), getExecuteMethod());
+    super(
+      generateExecutor(service, options, clientConfig),
+      options,
+      EdgeOptions.CAPABILITY,
+      (caps, method) -> new AddHasCasting().getImplementation(caps, method),
+      (caps, method) -> new AddHasCdp().getImplementation(caps, method));
   }
 
   private static EdgeDriverCommandExecutor generateExecutor(

java/src/org/openqa/selenium/firefox/ProfilesIni.java

@@ -136,10 +136,10 @@ protected File locateAppDataDirectory(Platform os) {
       appData =
           new File(
               MessageFormat.format(
-                  "{0}/Library/Application Support/Firefox", System.getenv("HOME")));
+                  "{0}/Library/Application Support/Firefox", System.getProperty("user.home")));
 
     } else {
-      appData = new File(MessageFormat.format("{0}/.mozilla/firefox", System.getenv("HOME")));
+      appData = new File(MessageFormat.format("{0}/.mozilla/firefox", System.getProperty("user.home")));
     }
 
     if (!appData.exists()) {