moved the bytype at module level, fixed the imports, reverted the return type

Author: rpallavisharma

py/selenium/webdriver/common/by.py

@@ -18,6 +18,7 @@
 
 from typing import Literal, Optional
 
+ByType = Literal["id", "xpath", "link text", "partial link text", "name", "tag name", "class name", "css selector"]
 
 class By:
     """Set of supported locator strategies.
@@ -73,14 +74,15 @@ class By:
     >>> element = driver.find_element(By.CSS_SELECTOR, "div.myElement")
     """
 
-    ID = "id"
-    XPATH = "xpath"
-    LINK_TEXT = "link text"
-    PARTIAL_LINK_TEXT = "partial link text"
-    NAME = "name"
-    TAG_NAME = "tag name"
-    CLASS_NAME = "class name"
-    CSS_SELECTOR = "css selector"
+  
+    ID: ByType = "id"
+    XPATH: ByType = "xpath"
+    LINK_TEXT: ByType = "link text"
+    PARTIAL_LINK_TEXT: ByType = "partial link text"
+    NAME: ByType = "name"
+    TAG_NAME: ByType = "tag name"
+    CLASS_NAME: ByType = "class name"
+    CSS_SELECTOR: ByType = "css selector"
 
     _custom_finders: dict[str, str] = {}
 
@@ -97,4 +99,4 @@ def clear_custom_finders(cls) -> None:
         cls._custom_finders.clear()
 
 
-ByType = Literal["id", "xpath", "link text", "partial link text", "name", "tag name", "class name", "css selector"]
+

py/selenium/webdriver/support/relative_locator.py

@@ -19,6 +19,7 @@
 
 from selenium.common.exceptions import WebDriverException
 from selenium.webdriver.common.by import ByType
+from selenium.webdriver.common.by import By
 from selenium.webdriver.remote.webelement import WebElement
 
 
@@ -48,8 +49,7 @@ def with_tag_name(tag_name: str) -> "RelativeBy":
     warnings.warn("This method is deprecated and may be removed in future versions. Please use `locate_with` instead.")
     if not tag_name:
         raise WebDriverException("tag_name can not be null")
-    return RelativeBy({"css selector": tag_name})
-
+    return RelativeBy({By.CSS_SELECTOR: tag_name})
 
 def locate_with(by: ByType, using: str) -> "RelativeBy":
     """Start searching for relative objects your search criteria with By.