Skip to content

Commit 06d52b5

Browse files
committed
Fix up the FirefoxDriverTests
Delete tests that don't apply any more, and fix up those that are meant to be used.
1 parent 7a15be8 commit 06d52b5

File tree

3 files changed

+69
-105
lines changed

3 files changed

+69
-105
lines changed

java/client/src/org/openqa/selenium/firefox/FirefoxBinary.java

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,10 @@ public void addCommandLineOptions(String... options) {
175175
extraOptions.addAll(Lists.newArrayList(options));
176176
}
177177

178+
void amendOptions(FirefoxOptions options) {
179+
options.addArguments(extraOptions);
180+
}
181+
178182
protected boolean isOnLinux() {
179183
return Platform.getCurrent().is(Platform.LINUX);
180184
}

java/client/src/org/openqa/selenium/firefox/FirefoxOptions.java

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -158,6 +158,7 @@ public boolean isLegacy() {
158158

159159
public FirefoxOptions setBinary(FirefoxBinary binary) {
160160
this.actualBinary = Preconditions.checkNotNull(binary);
161+
binary.amendOptions(this);
161162
this.binaryPath = null;
162163
return this;
163164
}
@@ -319,6 +320,10 @@ public FirefoxOptions setLogLevel(Level logLevel) {
319320
}
320321

321322
public FirefoxOptions addDesiredCapabilities(Capabilities desiredCapabilities) {
323+
if (desiredCapabilities == null) {
324+
return this;
325+
}
326+
322327
this.desiredCapabilities.merge(desiredCapabilities);
323328

324329
FirefoxProfile suggestedProfile = extractProfile(desiredCapabilities);
@@ -335,6 +340,7 @@ public FirefoxOptions addDesiredCapabilities(Capabilities desiredCapabilities) {
335340
}
336341
profile = suggestedProfile;
337342
}
343+
338344
Object binary = desiredCapabilities.getCapability(BINARY);
339345
if (binary != null) {
340346
if (binary instanceof File) {

0 commit comments

Comments
 (0)