Chromium and firefox are good

Author: nvborisenko

dotnet/src/webdriver/Chromium/ChromiumDriver.cs

@@ -471,6 +471,13 @@ protected override void Dispose(bool disposing)
                     this.devToolsSession = null;
                 }
 
+                if (this.SessionId is not null)
+                {
+                    this.Execute(DriverCommand.Quit, null);
+
+                    this.SessionId = null;
+                }
+
                 if (this.disposeDriverService)
                 {
                     this.driverService.Dispose();

dotnet/src/webdriver/Firefox/FirefoxDriver.cs

@@ -110,6 +110,8 @@ public class FirefoxDriver : WebDriver, IDevTools
             { GetFullPageScreenshotCommand, new HttpCommandInfo(HttpCommandInfo.GetCommand, "/session/{sessionId}/moz/screenshot/full") }
         };
 
+        private FirefoxDriverService driverService;
+        private bool disposeDriverService;
         private DevToolsSession devToolsSession;
 
         /// <summary>
@@ -125,7 +127,7 @@ public FirefoxDriver()
         /// </summary>
         /// <param name="options">The <see cref="FirefoxOptions"/> to be used with the Firefox driver.</param>
         public FirefoxDriver(FirefoxOptions options)
-            : this(FirefoxDriverService.CreateDefaultService(), options, RemoteWebDriver.DefaultCommandTimeout)
+            : this(FirefoxDriverService.CreateDefaultService(), disposeService: true, options, RemoteWebDriver.DefaultCommandTimeout)
         {
         }
 
@@ -167,7 +169,7 @@ public FirefoxDriver(string geckoDriverDirectory, FirefoxOptions options)
         /// <param name="options">The <see cref="FirefoxOptions"/> to be used with the Firefox driver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
         public FirefoxDriver(string geckoDriverDirectory, FirefoxOptions options, TimeSpan commandTimeout)
-            : this(FirefoxDriverService.CreateDefaultService(geckoDriverDirectory), options, commandTimeout)
+            : this(FirefoxDriverService.CreateDefaultService(geckoDriverDirectory), disposeService: true, options, commandTimeout)
         {
         }
 
@@ -188,8 +190,17 @@ public FirefoxDriver(FirefoxDriverService service, FirefoxOptions options)
         /// <param name="options">The <see cref="FirefoxOptions"/> to be used with the Firefox driver.</param>
         /// <param name="commandTimeout">The maximum amount of time to wait for each command.</param>
         public FirefoxDriver(FirefoxDriverService service, FirefoxOptions options, TimeSpan commandTimeout)
+            : this(service, disposeService: false, options, commandTimeout)
+        {
+
+        }
+
+        private FirefoxDriver(FirefoxDriverService service, bool disposeService, FirefoxOptions options, TimeSpan commandTimeout)
             : base(StartDriverServiceCommandExecutor(service, options, commandTimeout), ConvertOptionsToCapabilities(options))
         {
+            this.driverService = service;
+            this.disposeDriverService = disposeService;
+
             // Add the custom commands unique to Firefox
             this.AddCustomFirefoxCommands();
         }
@@ -477,6 +488,19 @@ protected override void Dispose(bool disposing)
                     this.devToolsSession.Dispose();
                     this.devToolsSession = null;
                 }
+
+                if (this.SessionId is not null)
+                {
+                    this.Execute(DriverCommand.Quit, null);
+
+                    this.SessionId = null;
+                }
+
+
+                if (this.disposeDriverService)
+                {
+                    this.driverService.Dispose();
+                }
             }
 
             base.Dispose(disposing);

dotnet/src/webdriver/WebDriver.cs

@@ -192,7 +192,7 @@ public bool IsActionExecutor
         /// <summary>
         /// Gets the <see cref="SessionId"/> for the current session of this driver.
         /// </summary>
-        public SessionId SessionId { get; private set; }
+        public SessionId SessionId { get; protected set; }
 
         /// <summary>
         /// Gets or sets the <see cref="IFileDetector"/> responsible for detecting
@@ -709,6 +709,7 @@ protected bool RegisterInternalDriverCommand(string commandName, CommandInfo com
         /// <param name="disposing">if its in the process of disposing</param>
         protected virtual void Dispose(bool disposing)
         {
+            // DO NOT SEND QUIT COMMAND IN BASE, CHILDS SHOULD IMPLEMENT IT. REMOVE IN FINAL MERGE.
             try
             {
                 if (this.SessionId is not null)