Skip to content

Commit 092e1b5

Browse files
committed
fix failures
1 parent 5d7db68 commit 092e1b5

File tree

2 files changed

+6
-8
lines changed

2 files changed

+6
-8
lines changed

.github/workflows/ci-ruby.yml

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -107,7 +107,6 @@ jobs:
107107
bazel test
108108
--keep_going
109109
--build_tests_only
110-
--flaky_test_attempts 2
111110
--local_test_jobs 1
112111
--test_size_filters large
113112
--test_tag_filters ${{ matrix.browser }}
@@ -133,7 +132,6 @@ jobs:
133132
bazel test
134133
--keep_going
135134
--build_tests_only
136-
--flaky_test_attempts 2
137135
--local_test_jobs 1
138136
--test_size_filters large
139137
--test_tag_filters ${{ matrix.browser }}-remote

rb/spec/integration/selenium/webdriver/element_spec.rb

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ module WebDriver
129129
key_reporter = wait_for_element(id: 'keyReporter')
130130

131131
key_reporter.send_keys([:shift, 'h'], 'ello')
132-
expect(key_reporter.attribute('value')).to eq('Nope')
132+
expect(key_reporter.attribute('value')).to eq('Hello')
133133
end
134134

135135
it 'handles file uploads' do
@@ -153,15 +153,15 @@ module WebDriver
153153
let(:prop_or_attr) { 'type' }
154154

155155
it '#dom_attribute returns attribute value' do
156-
expect(element.dom_attribute(prop_or_attr)).to eq 'nope'
156+
expect(element.dom_attribute(prop_or_attr)).to eq 'checkbox'
157157
end
158158

159159
it '#property returns property value' do
160-
expect(element.property(prop_or_attr)).to eq 'nope'
160+
expect(element.property(prop_or_attr)).to eq 'checkbox'
161161
end
162162

163163
it '#attribute returns value' do
164-
expect(element.attribute(prop_or_attr)).to eq 'nope'
164+
expect(element.attribute(prop_or_attr)).to eq 'checkbox'
165165
end
166166
end
167167

@@ -170,15 +170,15 @@ module WebDriver
170170
let(:prop_or_attr) { 'rows' }
171171

172172
it '#dom_attribute String' do
173-
expect(element.dom_attribute(prop_or_attr)).to eq 'nope'
173+
expect(element.dom_attribute(prop_or_attr)).to eq '5'
174174
end
175175

176176
it '#property returns Number' do
177177
expect(element.property(prop_or_attr)).to eq 5
178178
end
179179

180180
it '#attribute returns String' do
181-
expect(element.attribute(prop_or_attr)).to eq 'nope'
181+
expect(element.attribute(prop_or_attr)).to eq '5'
182182
end
183183
end
184184

0 commit comments

Comments
 (0)