incorporated review comments

Author: sandeepsuryaprasad

py/selenium/webdriver/chromium/service.py

@@ -35,14 +35,14 @@ def __init__(
         self,
         executable_path: str = None,
         port: int = 0,
-        service_args: typing.Optional[typing.List[str]] = None,
+        service_args: typing.Sequence[str] = None,
         log_output: SubprocessStdAlias = None,
         env: typing.Optional[typing.Mapping[str, str]] = None,
         **kwargs,
     ) -> None:
         if service_args is None:
             service_args = []
-        self._service_args = service_args
+        self.service_args = service_args
 
         if isinstance(log_output, str):
             self._service_args.append(f"--log-path={log_output}")
@@ -64,9 +64,9 @@ def service_args(self):
 
     @service_args.setter
     def service_args(self, value):
-        if not isinstance(value, list):
-            raise TypeError("service args must be a list")
-        self._service_args.extend(value)
+        if not isinstance(value, typing.Sequence):
+            raise TypeError("service args must be a sequence")
+        self._service_args = value
 
     def command_line_args(self) -> typing.List[str]:
         return [f"--port={self.port}"] + self._service_args

py/selenium/webdriver/edge/service.py

@@ -40,13 +40,13 @@ def __init__(
         port: int = 0,
         verbose: bool = False,
         log_output: SubprocessStdAlias = None,
-        service_args: typing.Optional[typing.List[str]] = None,
+        service_args: typing.Sequence[str] = None,
         env: typing.Optional[typing.Mapping[str, str]] = None,
         **kwargs,
     ) -> None:
         if service_args is None:
             service_args = []
-        self._service_args = service_args
+        self.service_args = service_args
 
         if verbose:
             warnings.warn(
@@ -70,6 +70,6 @@ def service_args(self):
 
     @service_args.setter
     def service_args(self, value):
-        if not isinstance(value, list):
-            raise TypeError("service args must be a list")
-        self._service_args.extend(value)
+        if not isinstance(value, typing.Sequence):
+            raise TypeError("service args must be a sequence")
+        self._service_args = value

py/selenium/webdriver/firefox/service.py

@@ -36,14 +36,14 @@ def __init__(
         self,
         executable_path: str = None,
         port: int = 0,
-        service_args: typing.Optional[typing.List[str]] = None,
+        service_args: typing.Sequence[str] = None,
         log_output: SubprocessStdAlias = None,
         env: typing.Optional[typing.Mapping[str, str]] = None,
         **kwargs,
     ) -> None:
         if service_args is None:
             service_args = []
-        self._service_args = service_args
+        self.service_args = service_args
 
         # Set a port for CDP
         if "--connect-existing" not in self._service_args:
@@ -64,9 +64,9 @@ def service_args(self):
 
     @service_args.setter
     def service_args(self, value):
-        if not isinstance(value, list):
-            raise TypeError("service args must be a list")
-        self._service_args.extend(value)
+        if not isinstance(value, typing.Sequence):
+            raise TypeError("service args must be a sequence")
+        self._service_args = value
 
     def command_line_args(self) -> typing.List[str]:
         return ["--port", f"{self.port}"] + self._service_args

py/selenium/webdriver/ie/service.py

@@ -28,7 +28,7 @@ def __init__(
         executable_path: str = None,
         port: int = 0,
         host: typing.Optional[str] = None,
-        service_args: typing.Optional[typing.List[str]] = None,
+        service_args: typing.Sequence[str] = None,
         log_level: typing.Optional[str] = None,
         log_output: SubprocessStdAlias = None,
         **kwargs,
@@ -46,7 +46,7 @@ def __init__(
         """
         if service_args is None:
             service_args = []
-        self._service_args = service_args
+        self.service_args = service_args
 
         if host:
             self._service_args.append(f"--host={host}")
@@ -66,9 +66,9 @@ def service_args(self):
 
     @service_args.setter
     def service_args(self, value):
-        if not isinstance(value, list):
-            raise TypeError("Service args must be a list")
-        self._service_args.extend(value)
+        if not isinstance(value, typing.Sequence):
+            raise TypeError("Service args must be a sequence")
+        self._service_args = value
 
     def command_line_args(self) -> typing.List[str]:
         return [f"--port={self.port}"] + self._service_args

py/selenium/webdriver/safari/service.py

@@ -37,14 +37,14 @@ def __init__(
         executable_path: str = None,
         port: int = 0,
         quiet: bool = None,
-        service_args: typing.Optional[typing.List[str]] = None,
+        service_args: typing.Sequence[str] = None,
         env: typing.Optional[typing.Mapping[str, str]] = None,
         reuse_service=False,
         **kwargs,
     ) -> None:
         if service_args is None:
             service_args = []
-        self._service_args = service_args
+        self.service_args = service_args
 
         if quiet is not None:
             warnings.warn("quiet is no longer needed to supress output", DeprecationWarning, stacklevel=2)
@@ -63,9 +63,9 @@ def service_args(self):
 
     @service_args.setter
     def service_args(self, value):
-        if not isinstance(value, list):
-            raise TypeError("service args must be a list")
-        self._service_args.extend(value)
+        if not isinstance(value, typing.Sequence):
+            raise TypeError("service args must be a sequence")
+        self._service_args = value
 
     @property
     def service_url(self) -> str:

py/selenium/webdriver/webkitgtk/service.py

@@ -37,13 +37,13 @@ def __init__(
         executable_path: str = DEFAULT_EXECUTABLE_PATH,
         port: int = 0,
         log_path: typing.Optional[str] = None,
-        service_args: typing.Optional[typing.List[str]] = None,
+        service_args: typing.Sequence[str] = None,
         env: typing.Optional[typing.Mapping[str, str]] = None,
         **kwargs,
     ):
         if service_args is None:
             service_args = []
-        self._service_args = service_args
+        self.service_args = service_args
 
         log_file = open(log_path, "wb") if log_path else None
         super().__init__(
@@ -60,9 +60,9 @@ def service_args(self):
 
     @service_args.setter
     def service_args(self, value):
-        if not isinstance(value, list):
-            raise TypeError("service args must be a list")
-        self._service_args.extend(value)
+        if not isinstance(value, typing.Sequence):
+            raise TypeError("service args must be a sequence")
+        self._service_args = value
 
     def command_line_args(self) -> typing.List[str]:
         return ["-p", f"{self.port}"] + self._service_args

py/selenium/webdriver/wpewebkit/service.py

@@ -37,13 +37,13 @@ def __init__(
         executable_path: str = DEFAULT_EXECUTABLE_PATH,
         port: int = 0,
         log_path: typing.Optional[str] = None,
-        service_args: typing.Optional[typing.List[str]] = None,
+        service_args: typing.Sequence[str] = None,
         env: typing.Optional[typing.Mapping[str, str]] = None,
         **kwargs,
     ):
         if service_args is None:
             service_args = []
-        self._service_args = service_args
+        self.service_args = service_args
 
         log_file = open(log_path, "wb") if log_path else None
         super().__init__(
@@ -60,9 +60,9 @@ def service_args(self):
 
     @service_args.setter
     def service_args(self, value):
-        if not isinstance(value, list):
-            raise TypeError("service args must be a list")
-        self._service_args.extend(value)
+        if not isinstance(value, typing.Sequence):
+            raise TypeError("service args must be a sequence")
+        self._service_args = value
 
     def command_line_args(self) -> typing.List[str]:
         return ["-p", f"{self.port}"] + self._service_args