Skip to content

Commit 09d3372

Browse files
authored
Merge branch 'trunk' into convert_to_BIG_SNAKE_CASE
2 parents fd93664 + 71a0629 commit 09d3372

File tree

2 files changed

+2
-8
lines changed

2 files changed

+2
-8
lines changed

MODULE.bazel

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ bazel_dep(name = "rules_cc", version = "0.0.9", dev_dependency = True)
1919

2020
bazel_dep(name = "rules_dotnet", version = "0.15.1")
2121
bazel_dep(name = "rules_java", version = "7.6.3")
22-
bazel_dep(name = "rules_jvm_external", version = "6.1")
22+
bazel_dep(name = "rules_jvm_external", version = "6.3")
2323
bazel_dep(name = "rules_nodejs", version = "6.2.0")
2424
bazel_dep(name = "rules_oci", version = "1.7.6")
2525
bazel_dep(name = "rules_pkg", version = "0.10.1")

py/selenium/webdriver/firefox/firefox_profile.py

Lines changed: 1 addition & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -276,17 +276,11 @@ def parse_manifest_json(content):
276276

277277
try:
278278
if zipfile.is_zipfile(addon_path):
279-
# Bug 944361 - We cannot use 'with' together with zipFile because
280-
# it will cause an exception thrown in Python 2.6.
281-
# TODO: use with statement when Python 2.x is no longer supported
282-
try:
283-
compressed_file = zipfile.ZipFile(addon_path, "r")
279+
with zipfile.ZipFile(addon_path, "r") as compressed_file:
284280
if "manifest.json" in compressed_file.namelist():
285281
return parse_manifest_json(compressed_file.read("manifest.json"))
286282

287283
manifest = compressed_file.read("install.rdf")
288-
finally:
289-
compressed_file.close()
290284
elif os.path.isdir(addon_path):
291285
manifest_json_filename = os.path.join(addon_path, "manifest.json")
292286
if os.path.exists(manifest_json_filename):

0 commit comments

Comments
 (0)