Skip to content

Commit 0b3f7dd

Browse files
committed
[grid] Replace Guava set and maps with Java equivalent for remaining Grid packages
1 parent fb832b9 commit 0b3f7dd

17 files changed

+67
-75
lines changed

java/src/org/openqa/selenium/grid/sessionmap/AddToSessionMap.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@
2424
import static org.openqa.selenium.remote.tracing.HttpTracing.newSpanAsChildOf;
2525
import static org.openqa.selenium.remote.tracing.Tags.HTTP_REQUEST;
2626

27-
import com.google.common.collect.ImmutableMap;
27+
import java.util.Map;
2828
import java.util.Objects;
2929
import org.openqa.selenium.grid.data.Session;
3030
import org.openqa.selenium.internal.Require;
@@ -61,7 +61,7 @@ public HttpResponse execute(HttpRequest req) {
6161

6262
sessions.add(session);
6363

64-
return new HttpResponse().setContent(asJson(ImmutableMap.of("value", true)));
64+
return new HttpResponse().setContent(asJson(Map.of("value", true)));
6565
}
6666
}
6767
}

java/src/org/openqa/selenium/grid/sessionmap/GetFromSessionMap.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import static org.openqa.selenium.remote.tracing.HttpTracing.newSpanAsChildOf;
2424
import static org.openqa.selenium.remote.tracing.Tags.HTTP_REQUEST;
2525

26-
import com.google.common.collect.ImmutableMap;
26+
import java.util.Map;
2727
import org.openqa.selenium.grid.data.Session;
2828
import org.openqa.selenium.internal.Require;
2929
import org.openqa.selenium.remote.SessionId;
@@ -56,7 +56,7 @@ public HttpResponse execute(HttpRequest req) {
5656
CAPABILITIES.accept(span, session.getCapabilities());
5757
span.setAttribute("session.uri", session.getUri().toString());
5858

59-
return new HttpResponse().setContent(asJson(ImmutableMap.of("value", session)));
59+
return new HttpResponse().setContent(asJson(Map.of("value", session)));
6060
}
6161
}
6262
}

java/src/org/openqa/selenium/grid/sessionmap/httpd/DefaultSessionMapConfig.java

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,21 +17,21 @@
1717

1818
package org.openqa.selenium.grid.sessionmap.httpd;
1919

20-
import com.google.common.collect.ImmutableMap;
20+
import java.util.Map;
2121
import org.openqa.selenium.grid.config.MapConfig;
2222

2323
class DefaultSessionMapConfig extends MapConfig {
2424

2525
public DefaultSessionMapConfig() {
2626
super(
27-
ImmutableMap.of(
27+
Map.of(
2828
"events",
29-
ImmutableMap.of(
29+
Map.of(
3030
"publish", "tcp://*:4442",
3131
"subscribe", "tcp://*:4443"),
3232
"sessions",
33-
ImmutableMap.of(
33+
Map.of(
3434
"implementation", "org.openqa.selenium.grid.sessionmap.local.LocalSessionMap"),
35-
"server", ImmutableMap.of("port", 5556)));
35+
"server", Map.of("port", 5556)));
3636
}
3737
}

java/src/org/openqa/selenium/grid/sessionmap/httpd/SessionMapServer.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,11 @@
2626
import static org.openqa.selenium.remote.http.Route.get;
2727

2828
import com.google.auto.service.AutoService;
29-
import com.google.common.collect.ImmutableMap;
30-
import com.google.common.collect.ImmutableSet;
3129
import java.io.Closeable;
3230
import java.io.IOException;
3331
import java.io.UncheckedIOException;
3432
import java.util.Collections;
33+
import java.util.Map;
3534
import java.util.Set;
3635
import java.util.logging.Level;
3736
import java.util.logging.Logger;
@@ -64,7 +63,7 @@ public String getDescription() {
6463

6564
@Override
6665
public Set<Role> getConfigurableRoles() {
67-
return ImmutableSet.of(EVENT_BUS_ROLE, HTTPD_ROLE, SESSION_MAP_ROLE);
66+
return Set.of(EVENT_BUS_ROLE, HTTPD_ROLE, SESSION_MAP_ROLE);
6867
}
6968

7069
@Override
@@ -100,9 +99,9 @@ protected Handlers createHandlers(Config config) {
10099
.addHeader("Content-Type", JSON_UTF_8)
101100
.setContent(
102101
asJson(
103-
ImmutableMap.of(
102+
Map.of(
104103
"value",
105-
ImmutableMap.of(
104+
Map.of(
106105
"ready",
107106
true,
108107
"message",

java/src/org/openqa/selenium/grid/sessionmap/redis/RedisBackedSessionMap.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,12 @@
2323
import static org.openqa.selenium.remote.RemoteTags.SESSION_ID_EVENT;
2424
import static org.openqa.selenium.remote.tracing.Tags.EXCEPTION;
2525

26-
import com.google.common.collect.ImmutableMap;
2726
import io.lettuce.core.KeyValue;
2827
import java.net.URI;
2928
import java.net.URISyntaxException;
3029
import java.time.Instant;
3130
import java.util.List;
31+
import java.util.Map;
3232
import java.util.logging.Logger;
3333
import org.openqa.selenium.Capabilities;
3434
import org.openqa.selenium.ImmutableCapabilities;
@@ -139,7 +139,7 @@ public boolean add(Session session) {
139139

140140
span.addEvent("Inserted into the database", attributeMap);
141141
connection.mset(
142-
ImmutableMap.of(
142+
Map.of(
143143
uriKey, uriValue,
144144
stereotypeKey, stereotypeJson,
145145
capabilitiesKey, capabilitiesJson,

java/src/org/openqa/selenium/grid/sessionqueue/ClearSessionQueue.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@
2323
import static org.openqa.selenium.remote.tracing.Tags.HTTP_REQUEST;
2424
import static org.openqa.selenium.remote.tracing.Tags.HTTP_RESPONSE;
2525

26-
import com.google.common.collect.ImmutableMap;
26+
import java.util.Map;
2727
import org.openqa.selenium.internal.Require;
2828
import org.openqa.selenium.remote.http.HttpHandler;
2929
import org.openqa.selenium.remote.http.HttpRequest;
@@ -56,14 +56,14 @@ public HttpResponse execute(HttpRequest req) {
5656
if (value != 0) {
5757
response.setContent(
5858
asJson(
59-
ImmutableMap.of(
59+
Map.of(
6060
"value", value,
6161
"message", "Cleared the new session request queue",
6262
"cleared_requests", value)));
6363
} else {
6464
response.setContent(
6565
asJson(
66-
ImmutableMap.of(
66+
Map.of(
6767
"value",
6868
value,
6969
"message",
@@ -81,7 +81,7 @@ public HttpResponse execute(HttpRequest req) {
8181
.setStatus((HTTP_INTERNAL_ERROR))
8282
.setContent(
8383
asJson(
84-
ImmutableMap.of(
84+
Map.of(
8585
"value",
8686
0,
8787
"message",

java/src/org/openqa/selenium/grid/sessionqueue/httpd/DefaultNewSessionQueueConfig.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,12 +17,12 @@
1717

1818
package org.openqa.selenium.grid.sessionqueue.httpd;
1919

20-
import com.google.common.collect.ImmutableMap;
20+
import java.util.Map;
2121
import org.openqa.selenium.grid.config.MapConfig;
2222

2323
class DefaultNewSessionQueueConfig extends MapConfig {
2424

2525
DefaultNewSessionQueueConfig() {
26-
super(ImmutableMap.of("server", ImmutableMap.of("port", 5559)));
26+
super(Map.of("server", Map.of("port", 5559)));
2727
}
2828
}

java/src/org/openqa/selenium/grid/sessionqueue/httpd/NewSessionQueueServer.java

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -25,12 +25,11 @@
2525
import static org.openqa.selenium.remote.http.Route.get;
2626

2727
import com.google.auto.service.AutoService;
28-
import com.google.common.collect.ImmutableMap;
29-
import com.google.common.collect.ImmutableSet;
3028
import java.io.Closeable;
3129
import java.io.IOException;
3230
import java.io.UncheckedIOException;
3331
import java.util.Collections;
32+
import java.util.Map;
3433
import java.util.Set;
3534
import java.util.logging.Level;
3635
import java.util.logging.Logger;
@@ -65,7 +64,7 @@ public String getDescription() {
6564

6665
@Override
6766
public Set<Role> getConfigurableRoles() {
68-
return ImmutableSet.of(HTTPD_ROLE, SESSION_QUEUE_ROLE);
67+
return Set.of(HTTPD_ROLE, SESSION_QUEUE_ROLE);
6968
}
7069

7170
@Override
@@ -100,9 +99,9 @@ protected Handlers createHandlers(Config config) {
10099
.addHeader("Content-Type", JSON_UTF_8)
101100
.setContent(
102101
asJson(
103-
ImmutableMap.of(
102+
Map.of(
104103
"value",
105-
ImmutableMap.of(
104+
Map.of(
106105
"ready",
107106
true,
108107
"message",

java/src/org/openqa/selenium/grid/sessionqueue/local/LocalNewSessionQueue.java

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@
2222
import static org.openqa.selenium.concurrent.ExecutorServices.shutdownGracefully;
2323

2424
import com.google.common.annotations.VisibleForTesting;
25-
import com.google.common.collect.ImmutableMap;
26-
import com.google.common.collect.ImmutableSet;
2725
import java.io.Closeable;
2826
import java.time.Duration;
2927
import java.time.Instant;
@@ -180,7 +178,7 @@ private void timeoutSessions() {
180178
sessionRequest.getRequestId().equals(entry.getKey())))
181179
.filter(entry -> isTimedOut(now, entry.getValue()))
182180
.map(Map.Entry::getKey)
183-
.collect(ImmutableSet.toImmutableSet());
181+
.collect(Collectors.toSet());
184182
} finally {
185183
readLock.unlock();
186184
}
@@ -258,9 +256,9 @@ public HttpResponse addToQueue(SessionRequest request) {
258256
res.setStatus(HTTP_INTERNAL_ERROR)
259257
.setContent(
260258
Contents.asJson(
261-
ImmutableMap.of(
259+
Map.of(
262260
"value",
263-
ImmutableMap.of(
261+
Map.of(
264262
"error", "session not created",
265263
"message", result.left().getMessage(),
266264
"stacktrace", result.left().getStackTrace()))));

java/src/org/openqa/selenium/grid/web/CheckContentTypeHeader.java

Lines changed: 6 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -19,9 +19,8 @@
1919

2020
import static java.net.HttpURLConnection.HTTP_INTERNAL_ERROR;
2121

22-
import com.google.common.collect.ImmutableMap;
23-
import com.google.common.collect.ImmutableSet;
2422
import com.google.common.net.MediaType;
23+
import java.util.Map;
2524
import java.util.Set;
2625
import org.openqa.selenium.internal.Require;
2726
import org.openqa.selenium.remote.http.Contents;
@@ -36,18 +35,17 @@ public class CheckContentTypeHeader implements Filter {
3635
.setStatus(HTTP_INTERNAL_ERROR)
3736
.setContent(
3837
Contents.asJson(
39-
ImmutableMap.of(
38+
Map.of(
4039
"value",
41-
ImmutableMap.of(
40+
Map.of(
4241
"error", "unknown error",
4342
"message", "Content-Type header is missing",
4443
"stacktrace", ""))));
4544

4645
private final Set<String> skipChecksOn;
4746

4847
public CheckContentTypeHeader(Set<String> skipChecksOn) {
49-
this.skipChecksOn =
50-
ImmutableSet.copyOf(Require.nonNull("URLs where checks are skipped", skipChecksOn));
48+
this.skipChecksOn = Set.copyOf(Require.nonNull("URLs where checks are skipped", skipChecksOn));
5149
}
5250

5351
@Override
@@ -81,9 +79,9 @@ private HttpResponse badType(String type) {
8179
.setStatus(HTTP_INTERNAL_ERROR)
8280
.setContent(
8381
Contents.asJson(
84-
ImmutableMap.of(
82+
Map.of(
8583
"value",
86-
ImmutableMap.of(
84+
Map.of(
8785
"error", "unknown error",
8886
"message",
8987
"Content-Type header does not indicate utf-8 encoded json: " + type,

0 commit comments

Comments
 (0)