Skip to content

Commit 0baf75d

Browse files
committed
fix callback
1 parent 9fb9d4a commit 0baf75d

File tree

1 file changed

+2
-15
lines changed

1 file changed

+2
-15
lines changed

py/selenium/webdriver/common/bidi/browsing_context.py

Lines changed: 2 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -535,7 +535,7 @@ class _EventManager:
535535
def __init__(self, conn, event_configs: dict[str, EventConfig]):
536536
self.conn = conn
537537
self.event_configs = event_configs
538-
self.subscriptions = {}
538+
self.subscriptions: dict = {}
539539
self._bidi_to_class = {config.bidi_event: config.event_class for config in event_configs.values()}
540540
self._available_events = ", ".join(sorted(event_configs.keys()))
541541

@@ -545,17 +545,6 @@ def validate_event(self, event: str) -> EventConfig:
545545
raise ValueError(f"Event '{event}' not found. Available events: {self._available_events}")
546546
return event_config
547547

548-
def create_event_callback(self, event_class: type, user_callback: Callable) -> Callable:
549-
"""
550-
Create a wrapped callback that parses event data.
551-
"""
552-
553-
def _callback(event_data):
554-
parsed_data = event_class.from_json(event_data)
555-
user_callback(parsed_data)
556-
557-
return _callback
558-
559548
def subscribe_to_event(self, bidi_event: str, contexts: Optional[list[str]] = None) -> None:
560549
"""Subscribe to a BiDi event if not already subscribed.
561550
@@ -593,9 +582,7 @@ def remove_callback_from_tracking(self, bidi_event: str, callback_id: int) -> No
593582
def add_event_handler(self, event: str, callback: Callable, contexts: Optional[list[str]] = None) -> int:
594583
event_config = self.validate_event(event)
595584

596-
# Create and register the wrapped callback
597-
wrapped_callback = self.create_event_callback(event_config.event_class, callback)
598-
callback_id = self.conn.add_callback(event_config.event_class, wrapped_callback)
585+
callback_id = self.conn.add_callback(event_config.event_class, callback)
599586

600587
# Subscribe to the event if needed
601588
self.subscribe_to_event(event_config.bidi_event, contexts)

0 commit comments

Comments
 (0)