Skip to content

Commit 0c3ed57

Browse files
committed
Enable some tests
1 parent d040dae commit 0c3ed57

File tree

2 files changed

+7
-11
lines changed

2 files changed

+7
-11
lines changed

dotnet/test/common/BiDi/WebExtension/WebExtensionTest.cs

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,6 @@ namespace OpenQA.Selenium.BiDi.WebExtension;
2727
class WebExtensionTest : BiDiTestFixture
2828
{
2929
[Test]
30-
[IgnoreBrowser(Selenium.Browser.Chrome, "Web extensions are not supported yet?")]
31-
[IgnoreBrowser(Selenium.Browser.Edge, "Web extensions are not supported yet?")]
3230
public async Task CanInstallPathWebExtension()
3331
{
3432
string path = Path.GetFullPath("common/extensions/webextensions-selenium-example");
@@ -39,8 +37,8 @@ public async Task CanInstallPathWebExtension()
3937
}
4038

4139
[Test]
42-
[IgnoreBrowser(Selenium.Browser.Chrome, "Web extensions are not supported yet?")]
43-
[IgnoreBrowser(Selenium.Browser.Edge, "Web extensions are not supported yet?")]
40+
[IgnoreBrowser(Selenium.Browser.Chrome, "Archived and Base64 extensions are not supported?")]
41+
[IgnoreBrowser(Selenium.Browser.Edge, "Archived and Base64 extensions are not supported?")]
4442
public async Task CanInstallArchiveWebExtension()
4543
{
4644
string path = LocateRelativePath("common/extensions/webextensions-selenium-example.zip");
@@ -51,8 +49,8 @@ public async Task CanInstallArchiveWebExtension()
5149
}
5250

5351
[Test]
54-
[IgnoreBrowser(Selenium.Browser.Chrome, "Web extensions are not supported yet?")]
55-
[IgnoreBrowser(Selenium.Browser.Edge, "Web extensions are not supported yet?")]
52+
[IgnoreBrowser(Selenium.Browser.Chrome, "Archived and Base64 extensions are not supported?")]
53+
[IgnoreBrowser(Selenium.Browser.Edge, "Archived and Base64 extensions are not supported?")]
5654
public async Task CanInstallBase64WebExtension()
5755
{
5856
var path = LocateRelativePath("common/extensions/webextensions-selenium-example.zip");
@@ -65,8 +63,6 @@ public async Task CanInstallBase64WebExtension()
6563
}
6664

6765
[Test]
68-
[IgnoreBrowser(Selenium.Browser.Chrome, "Web extensions are not supported yet?")]
69-
[IgnoreBrowser(Selenium.Browser.Edge, "Web extensions are not supported yet?")]
7066
public async Task CanUninstallExtension()
7167
{
7268
string path = LocateRelativePath("common/extensions/webextensions-selenium-example");
@@ -76,7 +72,7 @@ public async Task CanUninstallExtension()
7672
await result.Extension.UninstallAsync();
7773
}
7874

79-
private string LocateRelativePath(string path)
75+
private static string LocateRelativePath(string path)
8076
{
8177
try
8278
{

dotnet/test/common/Environment/DriverFactory.cs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,7 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
8686
options = GetDriverOptions<ChromeOptions>(driverType, driverOptions);
8787

8888
var chromeOptions = (ChromeOptions)options;
89-
chromeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage");
89+
chromeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage", "--remote-debugging-pipe", "--enable-unsafe-extension-debugging");
9090

9191
service = CreateService<ChromeDriverService>();
9292
if (!string.IsNullOrEmpty(this.browserBinaryLocation))
@@ -104,7 +104,7 @@ public IWebDriver CreateDriverWithOptions(Type driverType, DriverOptions driverO
104104
options = GetDriverOptions<EdgeOptions>(driverType, driverOptions);
105105

106106
var edgeOptions = (EdgeOptions)options;
107-
edgeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage");
107+
edgeOptions.AddArguments("--no-sandbox", "--disable-dev-shm-usage", "--remote-debugging-pipe", "--enable-unsafe-extension-debugging");
108108

109109
service = CreateService<EdgeDriverService>();
110110
if (!string.IsNullOrEmpty(this.browserBinaryLocation))

0 commit comments

Comments
 (0)