Skip to content

Commit 0dacbfb

Browse files
committed
[rb] Fixing linting issues
1 parent ba02778 commit 0dacbfb

File tree

3 files changed

+6
-2
lines changed

3 files changed

+6
-2
lines changed

rb/.rubocop.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -93,6 +93,10 @@ Naming/MethodParameterName:
9393
- id
9494
- io
9595

96+
Naming/PredicateMethod:
97+
Exclude:
98+
- 'rb/lib/selenium/webdriver/common/file_reaper.rb'
99+
96100
RSpec/AnyInstance:
97101
Enabled: false
98102

rb/lib/selenium/webdriver/bidi/network/url_pattern.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,7 @@ def to_url_pattern(*url_patterns)
4444
type: 'pattern',
4545
protocol: uri.scheme || '',
4646
hostname: uri.host || '',
47-
port: uri.port.to_s || '',
47+
port: uri.port.to_s,
4848
pathname: uri.path || '',
4949
search: uri.query || ''
5050
}

rb/lib/selenium/webdriver/common/socket_poller.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -106,7 +106,7 @@ def conn_completed?(sock)
106106
sock.getsockopt(Socket::SOL_SOCKET, Socket::SO_ERROR).int.zero?
107107
end
108108

109-
def with_timeout
109+
def with_timeout?
110110
max_time = current_time + @timeout
111111

112112
until current_time > max_time

0 commit comments

Comments
 (0)