Storage

Author: nvborisenko

dotnet/src/webdriver/BiDi/Modules/Storage/DeleteCookiesCommand.cs

@@ -26,12 +26,7 @@ namespace OpenQA.Selenium.BiDi.Modules.Storage;
 internal class DeleteCookiesCommand(DeleteCookiesCommandParameters @params)
     : Command<DeleteCookiesCommandParameters>(@params, "storage.deleteCookies");
 
-internal record DeleteCookiesCommandParameters : CommandParameters
-{
-    public CookieFilter? Filter { get; set; }
-
-    public PartitionDescriptor? Partition { get; set; }
-}
+internal record DeleteCookiesCommandParameters(CookieFilter? Filter, PartitionDescriptor? Partition) : CommandParameters;
 
 public record DeleteCookiesOptions : GetCookiesOptions;
 

dotnet/src/webdriver/BiDi/Modules/Storage/GetCookiesCommand.cs

@@ -30,12 +30,7 @@ namespace OpenQA.Selenium.BiDi.Modules.Storage;
 internal class GetCookiesCommand(GetCookiesCommandParameters @params)
     : Command<GetCookiesCommandParameters>(@params, "storage.getCookies");
 
-internal record GetCookiesCommandParameters : CommandParameters
-{
-    public CookieFilter? Filter { get; set; }
-
-    public PartitionDescriptor? Partition { get; set; }
-}
+internal record GetCookiesCommandParameters(CookieFilter? Filter, PartitionDescriptor? Partition) : CommandParameters;
 
 public record GetCookiesOptions : CommandOptions
 {

dotnet/src/webdriver/BiDi/Modules/Storage/SetCookieCommand.cs

@@ -27,10 +27,7 @@ namespace OpenQA.Selenium.BiDi.Modules.Storage;
 internal class SetCookieCommand(SetCookieCommandParameters @params)
     : Command<SetCookieCommandParameters>(@params, "storage.setCookie");
 
-internal record SetCookieCommandParameters(PartialCookie Cookie) : CommandParameters
-{
-    public PartitionDescriptor? Partition { get; set; }
-}
+internal record SetCookieCommandParameters(PartialCookie Cookie, PartitionDescriptor? Partition) : CommandParameters;
 
 public record PartialCookie(string Name, Network.BytesValue Value, string Domain)
 {

dotnet/src/webdriver/BiDi/Modules/Storage/StorageModule.cs

@@ -28,38 +28,21 @@ public class StorageModule(Broker broker) : Module(broker)
 {
     public async Task<GetCookiesResult> GetCookiesAsync(GetCookiesOptions? options = null)
     {
-        var @params = new GetCookiesCommandParameters();
-
-        if (options is not null)
-        {
-            @params.Filter = options.Filter;
-            @params.Partition = options.Partition;
-        }
+        var @params = new GetCookiesCommandParameters(options?.Filter, options?.Partition);
 
         return await Broker.ExecuteCommandAsync<GetCookiesCommand, GetCookiesResult>(new GetCookiesCommand(@params), options).ConfigureAwait(false);
     }
 
     public async Task<DeleteCookiesResult> DeleteCookiesAsync(DeleteCookiesOptions? options = null)
     {
-        var @params = new DeleteCookiesCommandParameters();
-
-        if (options is not null)
-        {
-            @params.Filter = options.Filter;
-            @params.Partition = options.Partition;
-        }
+        var @params = new DeleteCookiesCommandParameters(options?.Filter, options?.Partition);
 
         return await Broker.ExecuteCommandAsync<DeleteCookiesCommand, DeleteCookiesResult>(new DeleteCookiesCommand(@params), options).ConfigureAwait(false);
     }
 
     public async Task<SetCookieResult> SetCookieAsync(PartialCookie cookie, SetCookieOptions? options = null)
     {
-        var @params = new SetCookieCommandParameters(cookie);
-
-        if (options is not null)
-        {
-            @params.Partition = options.Partition;
-        }
+        var @params = new SetCookieCommandParameters(cookie, options?.Partition);
 
         return await Broker.ExecuteCommandAsync<SetCookieCommand, SetCookieResult>(new SetCookieCommand(@params), options).ConfigureAwait(false);
     }