Caching lenght in loops for support package

Author: LuisOsv

java/src/org/openqa/selenium/support/FindAll.java

@@ -52,8 +52,9 @@ public By buildIt(Object annotation, Field field) {
       assertValidFindAll(findBys);
 
       FindBy[] findByArray = findBys.value();
-      By[] byArray = new By[findByArray.length];
-      for (int i = 0; i < findByArray.length; i++) {
+      int findByArrayLength = findByArray.length;
+      By[] byArray = new By[findByArrayLength];
+      for (int i = 0; i < findByArrayLength; i++) {
         byArray[i] = buildByFromFindBy(findByArray[i]);
       }
 

java/src/org/openqa/selenium/support/FindBys.java

@@ -51,8 +51,9 @@ public By buildIt(Object annotation, Field field) {
       assertValidFindBys(findBys);
 
       FindBy[] findByArray = findBys.value();
-      By[] byArray = new By[findByArray.length];
-      for (int i = 0; i < findByArray.length; i++) {
+      int findByArrayLength = findByArray.length; 
+      By[] byArray = new By[findByArrayLength];
+      for (int i = 0; i < findByArrayLength; i++) {
         byArray[i] = buildByFromFindBy(findByArray[i]);
       }
 

java/src/org/openqa/selenium/support/events/EventFiringDecorator.java

@@ -317,10 +317,11 @@ private Method findMatchingMethod(WebDriverListener listener, String methodName,
 
   private boolean parametersMatch(Method m, Object[] args) {
     Class<?>[] params = m.getParameterTypes();
-    if (params.length != args.length) {
+    int parameterCount = params.length;
+    if (parameterCount != args.length) {
       return false;
     }
-    for (int i = 0; i < params.length; i++) {
+    for (int i = 0; i < parameterCount; i++) {
       Class<?> param = params[i];
       if (param.isPrimitive()) {
         if (boolean.class.equals(param)) {

java/src/org/openqa/selenium/support/pagefactory/ByChained.java

@@ -58,12 +58,13 @@ public WebElement findElement(SearchContext context) {
 
   @Override
   public List<WebElement> findElements(SearchContext context) {
-    if (bys.length == 0) {
+    int numberOfLocators = bys.length;
+    if (numberOfLocators == 0) {
       return new ArrayList<>();
     }
 
     List<WebElement> elems = bys[0].findElements(context);
-    for (int i = 1; i < bys.length; i++) {
+    for (int i = 1; i < numberOfLocators; i++) {
       if (elems.isEmpty()) {
         break; // if any one of the bys finds no elements, then return no elements
       }

java/src/org/openqa/selenium/support/ui/Quotes.java

@@ -40,10 +40,11 @@ public static String escape(String toEscape) {
       String[] substringsWithoutQuotes = toEscape.split("\"");
 
       StringBuilder quoted = new StringBuilder("concat(");
-      for (int i = 0; i < substringsWithoutQuotes.length; i++) {
+      int substringCount = substringsWithoutQuotes.length;
+      for (int i = 0; i < substringCount; i++) {
         quoted.append("\"").append(substringsWithoutQuotes[i]).append("\"");
         quoted.append(
-            ((i == substringsWithoutQuotes.length - 1)
+            ((i == substringCount - 1)
                 ? (quoteIsLast ? ", '\"')" : ")")
                 : ", '\"', "));
       }