[rb] enable specs for new firefox functionality

Author: lmtierney

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

@@ -21,7 +21,7 @@
 
 module Selenium
   module WebDriver
-    not_compliant_on browser: [:safari, :firefox] do
+    not_compliant_on browser: [:safari] do
       not_compliant_on browser: [:firefox, :ff_nightly], driver: :remote do
         describe ActionBuilder do
           describe 'Key actions' do
@@ -70,68 +70,69 @@ module WebDriver
               expect(keylogger.text).to match(/keyup *$/)
             end
 
-            # These requires pointer actions to be working in Firefox first
-            not_compliant_on driver: [:firefox, :ff_nightly] do
-              it 'can send keys to element' do
-                driver.navigate.to url_for('formPage.html')
+            it 'can send multiple send_keys commands' do
+              driver.navigate.to url_for('formPage.html')
 
-                input = driver.find_element(css: '#working')
+              input = driver.find_element(css: '#working')
+              input.click
 
-                driver.action.send_keys(input, 'abcd').perform
-                wait.until { input.attribute(:value).length == 4 }
-                expect(input.attribute(:value)).to eq('abcd')
-              end
+              driver.action.send_keys('abcd', 'dcba').perform
+              wait.until { input.attribute(:value).length == 8 }
+              expect(input.attribute(:value)).to eq('abcddcba')
+            end
 
-              it 'can send multiple send_keys commands' do
+            # Certain non-ascii keys are not working in Firefox yet (known but un-filed bug)
+            not_compliant_on driver: [:firefox, :ff_nightly] do
+              it 'can send non-ascii keys' do
                 driver.navigate.to url_for('formPage.html')
 
                 input = driver.find_element(css: '#working')
+                input.click
 
-                driver.action.send_keys(input, 'abcd', 'dcba').perform
-                wait.until { input.attribute(:value).length == 8 }
-                expect(input.attribute(:value)).to eq('abcddcba')
+                driver.action.send_keys('abcd', :left, 'a').perform
+                wait.until { input.attribute(:value).length == 5 }
+                expect(input.attribute(:value)).to eq('abcad')
               end
+            end
 
-              # Certain non-ascii keys are not working in Firefox yet (known but un-filed bug)
-              it 'can send non-ascii keys' do
+            # These requires pointer actions to be working in Firefox first
+            not_compliant_on driver: :firefox do
+              it 'can send keys to element' do
                 driver.navigate.to url_for('formPage.html')
 
                 input = driver.find_element(css: '#working')
 
-                driver.action.send_keys(input, 'abcd', :left, 'a').perform
-                wait.until { input.attribute(:value).length == 5 }
-                expect(input.attribute(:value)).to eq('abcad')
+                driver.action.send_keys(input, 'abcd').perform
+                wait.until { input.attribute(:value).length == 4 }
+                expect(input.attribute(:value)).to eq('abcd')
               end
             end
 
-            compliant_on driver: :firefox do
-              it 'can release pressed keys via release action' do
-                driver.navigate.to url_for('javascriptPage.html')
+            it 'can release pressed keys via release action' do
+              driver.navigate.to url_for('javascriptPage.html')
 
-                event_input = driver.find_element(id: 'theworks')
-                keylogger = driver.find_element(id: 'result')
+              event_input = driver.find_element(id: 'theworks')
+              keylogger = driver.find_element(id: 'result')
 
-                event_input.click
+              event_input.click
 
-                driver.action.key_down(:shift).perform
-                wait.until { keylogger.text.include? 'down' }
-                expect(keylogger.text).to match(/keydown *$/)
+              driver.action.key_down(:shift).perform
+              wait.until { keylogger.text.include? 'down' }
+              expect(keylogger.text).to match(/keydown *$/)
 
-                driver.action.release_actions
-                wait.until { keylogger.text.include? 'up' }
-                expect(keylogger.text).to match(/keyup *$/)
-              end
+              driver.action.release_actions
+              wait.until { keylogger.text.include? 'up' }
+              expect(keylogger.text).to match(/keyup *$/)
             end
           end # Key actions
 
-          not_compliant_on browser: [:safari, :firefox, :ff_nightly] do
+          not_compliant_on browser: [:safari, :firefox] do
             describe 'Pointer actions' do
               it 'clicks an element' do
-                driver.navigate.to url_for('formPage.html')
-                original_title = driver.title
-                driver.action.click(driver.find_element(id: 'imageButton')).perform
-                Wait.new.until { driver.title != original_title }
-                expect(driver.title).to eq 'We Arrive Here'
+                driver.navigate.to url_for('javascriptPage.html')
+                element = driver.find_element(id: 'clickField')
+                driver.action.click(element).perform
+                expect(element.attribute(:value)).to eq('Clicked')
               end
 
               it 'can drag and drop' do
@@ -149,14 +150,19 @@ module WebDriver
                 expect(text).to eq('Dropped!')
               end
 
-              it 'double clicks an element' do
-                driver.navigate.to url_for('javascriptPage.html')
-                element = driver.find_element(id: 'doubleClickField')
+              # Pending bug with Firefox
+              not_compliant_on driver: [:ff_nightly] do
+                it 'double clicks an element' do
+                  driver.navigate.to url_for('javascriptPage.html')
+                  element = driver.find_element(id: 'doubleClickField')
 
-                driver.action.double_click(element).perform
-                expect(element.attribute(:value)).to eq('DoubleClicked')
+                  driver.action.double_click(element).perform
+                  expect(element.attribute(:value)).to eq('DoubleClicked')
+                end
               end
-              not_compliant_on browser: :phantomjs do
+
+              # Pending bug with Firefox
+              not_compliant_on browser: [:phantomjs, :ff_nightly] do
                 it 'context clicks an element' do
                   driver.navigate.to url_for('javascriptPage.html')
                   element = driver.find_element(id: 'doubleClickField')
@@ -166,7 +172,7 @@ module WebDriver
                 end
               end
 
-              compliant_on driver: :firefox do
+              compliant_on driver: :ff_nightly do
                 it 'can release pressed buttons via release action' do
                   driver.navigate.to url_for('javascriptPage.html')
 

rb/spec/integration/selenium/webdriver/timeout_spec.rb

@@ -91,8 +91,11 @@ module WebDriver
         # w3c default is 300,000
         after { driver.manage.timeouts.page_load = 300000 }
 
-        it 'should be able to set the page load timeout' do
-          expect { driver.manage.timeouts.page_load = 2 }.to_not raise_exception
+        # The pageLoad change is currently only in Nightly
+        not_compliant_on driver: :firefox do
+          it 'should be able to set the page load timeout' do
+            expect { driver.manage.timeouts.page_load = 2 }.to_not raise_exception
+          end
         end
       end
     end