[rb][BiDi] Create browser module, added user context related methods (#15371)

* Create browser module, added user context related methods

* Fix formatting issues

* Fix delete cookie test

* Fix tests for firefox browser contexts

Author: aguspe

rb/lib/selenium/webdriver/bidi.rb

@@ -23,6 +23,7 @@ class BiDi
       autoload :Session, 'selenium/webdriver/bidi/session'
       autoload :LogInspector, 'selenium/webdriver/bidi/log_inspector'
       autoload :LogHandler, 'selenium/webdriver/bidi/log_handler'
+      autoload :Browser, 'selenium/webdriver/bidi/browser'
       autoload :BrowsingContext, 'selenium/webdriver/bidi/browsing_context'
       autoload :Struct, 'selenium/webdriver/bidi/struct'
       autoload :Network, 'selenium/webdriver/bidi/network'

rb/lib/selenium/webdriver/bidi/browser.rb

@@ -0,0 +1,42 @@
+# frozen_string_literal: true
+
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+module Selenium
+  module WebDriver
+    class BiDi
+      class Browser
+        def initialize(bidi)
+          @bidi = bidi
+        end
+
+        def create_user_context
+          @bidi.send_cmd('browser.createUserContext')
+        end
+
+        def user_contexts
+          @bidi.send_cmd('browser.getUserContexts')
+        end
+
+        def remove_user_context(user_context)
+          @bidi.send_cmd('browser.removeUserContext', userContext: user_context)
+        end
+      end
+    end # BiDi
+  end # WebDriver
+end # Selenium

rb/lib/selenium/webdriver/common/manager.rb

@@ -79,6 +79,8 @@ def cookie_named(name)
       #
 
       def delete_cookie(name)
+        raise ArgumentError, 'Cookie name cannot be null or empty' if name.nil? || name.to_s.strip.empty?
+
         @bridge.delete_cookie name
       end
 

rb/sig/lib/selenium/webdriver/bidi/browser.rbs

@@ -0,0 +1,17 @@
+module Selenium
+  module WebDriver
+    class BiDi
+      class Browser
+        @bidi: BiDi
+
+        def initialize: (BiDi bidi) -> void
+
+        def create_user_context: () -> Hash[String, String]
+
+        def user_contexts: () -> Array[Hash[String, String]]
+
+        def remove_user_context: (String user_context) -> Hash[nil, nil]
+      end
+    end
+  end
+end

rb/spec/integration/selenium/webdriver/bidi/browser_spec.rb

@@ -0,0 +1,77 @@
+# frozen_string_literal: true
+
+# Licensed to the Software Freedom Conservancy (SFC) under one
+# or more contributor license agreements.  See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership.  The SFC licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License.  You may obtain a copy of the License at
+#
+#   http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing,
+# software distributed under the License is distributed on an
+# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+# KIND, either express or implied.  See the License for the
+# specific language governing permissions and limitations
+# under the License.
+
+require_relative '../spec_helper'
+
+module Selenium
+  module WebDriver
+    class BiDi
+      describe Browser, exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
+                        only: {browser: %i[chrome edge firefox]} do
+        it 'creates an user context' do
+          reset_driver!(web_socket_url: true) do |driver|
+            browser = described_class.new(driver.bidi)
+            user_context = browser.create_user_context
+            expect(user_context).not_to be_nil
+            expect(user_context['userContext']).to be_a String
+          end
+        end
+
+        it 'gets user contexts' do
+          reset_driver!(web_socket_url: true) do |driver|
+            browser = described_class.new(driver.bidi)
+            created_context_id = browser.create_user_context['userContext']
+            all_context_ids = browser.user_contexts['userContexts'].map { |c| c['userContext'] }
+
+            expect(all_context_ids).to include(created_context_id)
+          end
+        end
+
+        it 'removes an user context' do
+          reset_driver!(web_socket_url: true) do |driver|
+            browser = described_class.new(driver.bidi)
+            context_id_to_remove = browser.create_user_context['userContext']
+            browser.remove_user_context(context_id_to_remove)
+            all_ids_after_removal = browser.user_contexts['userContexts'].map { |c| c['userContext'] }
+
+            expect(all_ids_after_removal).not_to include(context_id_to_remove)
+          end
+        end
+
+        it 'throws an error when removing the default user context' do
+          reset_driver!(web_socket_url: true) do |driver|
+            browser = described_class.new(driver.bidi)
+            expect {
+              browser.remove_user_context('default')
+            }.to raise_error(Error::WebDriverError, /user context cannot be removed/)
+          end
+        end
+
+        it 'throws an error when removing a non-existent user context' do
+          reset_driver!(web_socket_url: true) do |driver|
+            browser = described_class.new(driver.bidi)
+            expect {
+              browser.remove_user_context('fake_context')
+            }.to raise_error(Error::WebDriverError)
+          end
+        end
+      end
+    end
+  end
+end