Do not log command parameters in HttpCommandExecutor at all

RenderMichael · RenderMichael · commit 15459e7491e6 · 2025-02-03T12:31:25.000-05:00
diff --git a/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs b/dotnet/src/webdriver/Remote/HttpCommandExecutor.cs
@@ -170,10 +170,6 @@ public virtual async Task<Response> ExecuteAsync(Command commandToExecute)
             }
 
             if (_logger.IsEnabled(LogEventLevel.Trace))
-            {
-                _logger.Debug($"Executing command: [{commandToExecute.SessionId}]: {commandToExecute.Name} {commandToExecute.ParametersAsJsonString}");
-            }
-            else if (_logger.IsEnabled(LogEventLevel.Debug))
             {
                 _logger.Debug($"Executing command: [{commandToExecute.SessionId}]: {commandToExecute.Name}");
             }

Original file line number	Diff line number	Diff line change
`@@ -170,10 +170,6 @@ public virtual async Task<Response> ExecuteAsync(Command commandToExecute)`
`170`	`170`	`}`
`171`	`171`
`172`	`172`	`if (_logger.IsEnabled(LogEventLevel.Trace))`
`173`		`- {`
`174`		`- _logger.Debug($"Executing command: [{commandToExecute.SessionId}]: {commandToExecute.Name} {commandToExecute.ParametersAsJsonString}");`
`175`		`- }`
`176`		`- else if (_logger.IsEnabled(LogEventLevel.Debug))`
`177`	`173`	`{`
`178`	`174`	`_logger.Debug($"Executing command: [{commandToExecute.SessionId}]: {commandToExecute.Name}");`
`179`	`175`	`}`