Skip to content

Commit 19b5468

Browse files
committed
use custom pages fixture
1 parent ea6b3ff commit 19b5468

File tree

1 file changed

+16
-9
lines changed

1 file changed

+16
-9
lines changed

py/test/selenium/webdriver/common/bidi_webextension_tests.py

Lines changed: 16 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -118,6 +118,17 @@ def test_install_with_extension_id_uninstall(self, driver, pages):
118118
class TestChromiumWebExtension:
119119
"""Chrome/Edge-specific WebExtension tests with custom driver."""
120120

121+
@pytest.fixture
122+
def pages_chromium(self, chromium_driver, pages):
123+
class ChromiumPages:
124+
def url(self, name, localhost=False):
125+
return pages.url(name, localhost)
126+
127+
def load(self, name):
128+
chromium_driver.get(self.url(name))
129+
130+
return ChromiumPages()
131+
121132
@pytest.fixture
122133
def chromium_driver(self, request):
123134
driver_option = request.config.option.drivers[0].lower()
@@ -142,27 +153,23 @@ def chromium_driver(self, request):
142153
yield driver
143154
driver.quit()
144155

145-
def test_install_extension_path(self, chromium_driver, pages):
156+
def test_install_extension_path(self, chromium_driver, pages_chromium):
146157
"""Test installing an extension from a directory path."""
147158
path = os.path.join(extensions, EXTENSION_PATH)
148159
ext_info = chromium_driver.webextension.install(path=path)
149160

150-
chromium_driver.get("https://www.webpagetest.org/blank.html")
151-
152-
verify_extension_injection(chromium_driver, pages)
161+
verify_extension_injection(chromium_driver, pages_chromium)
153162
uninstall_extension_and_verify_extension_uninstalled(chromium_driver, ext_info)
154163

155-
def test_install_unsigned_extension(self, chromium_driver, pages):
164+
def test_install_unsigned_extension(self, chromium_driver, pages_chromium):
156165
"""Test installing an unsigned extension."""
157166
path = os.path.join(extensions, "webextensions-selenium-example")
158167
ext_info = chromium_driver.webextension.install(path=path)
159168

160-
chromium_driver.get("https://www.webpagetest.org/blank.html")
161-
162-
verify_extension_injection(chromium_driver, pages)
169+
verify_extension_injection(chromium_driver, pages_chromium)
163170
uninstall_extension_and_verify_extension_uninstalled(chromium_driver, ext_info)
164171

165-
def test_install_with_extension_id_uninstall(self, chromium_driver, pages):
172+
def test_install_with_extension_id_uninstall(self, chromium_driver):
166173
"""Test uninstalling an extension using just the extension ID."""
167174
path = os.path.join(extensions, EXTENSION_PATH)
168175
ext_info = chromium_driver.webextension.install(path=path)

0 commit comments

Comments
 (0)