Skip to content

Commit 1b54248

Browse files
Delta456cgoldberg
andauthored
[py][BiDi] use constant for LogLevel (#15677)
Co-authored-by: Corey Goldberg <[email protected]>
1 parent 754aa10 commit 1b54248

File tree

2 files changed

+13
-3
lines changed

2 files changed

+13
-3
lines changed

py/selenium/webdriver/common/bidi/log.py

Lines changed: 9 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,3 +68,12 @@ def from_json(cls, json):
6868
stacktrace=json["stackTrace"],
6969
type_=json["type"],
7070
)
71+
72+
73+
class LogLevel:
74+
"""Represents log level."""
75+
76+
DEBUG = "debug"
77+
INFO = "info"
78+
WARN = "warn"
79+
ERROR = "error"

py/test/selenium/webdriver/common/bidi_script_tests.py

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -15,6 +15,7 @@
1515
# specific language governing permissions and limitations
1616
# under the License.
1717

18+
from selenium.webdriver.common.bidi.log import LogLevel
1819
from selenium.webdriver.common.by import By
1920
from selenium.webdriver.support.ui import WebDriverWait
2021

@@ -31,7 +32,7 @@ def test_logs_console_messages(driver, pages):
3132
WebDriverWait(driver, 5).until(lambda _: log_entries)
3233

3334
log_entry = log_entries[0]
34-
assert log_entry.level == "info"
35+
assert log_entry.level == LogLevel.INFO
3536
assert log_entry.method == "log"
3637
assert log_entry.text == "Hello, world!"
3738
assert log_entry.type_ == "console"
@@ -55,7 +56,7 @@ def log_error(entry):
5556
assert len(log_entries) == 1
5657

5758
log_entry = log_entries[0]
58-
assert log_entry.level == "error"
59+
assert log_entry.level == LogLevel.ERROR
5960
assert log_entry.method == "error"
6061
assert log_entry.text == "I am console error"
6162
assert log_entry.type_ == "console"
@@ -105,7 +106,7 @@ def test_javascript_error_messages(driver, pages):
105106

106107
log_entry = log_entries[0]
107108
assert log_entry.text == "Error: Not working"
108-
assert log_entry.level == "error"
109+
assert log_entry.level == LogLevel.ERROR
109110
assert log_entry.type_ == "javascript"
110111

111112

0 commit comments

Comments
 (0)