Skip to content

Commit 1c18799

Browse files
authored
[rb] Add guard for beta firefox (#16153)
1 parent 2dad5fa commit 1c18799

File tree

3 files changed

+3
-14
lines changed

3 files changed

+3
-14
lines changed

rb/spec/integration/selenium/webdriver/network_spec.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@
2121

2222
module Selenium
2323
module WebDriver
24-
describe Network, exclude: {version: GlobalTestEnv.beta_chrome_version},
24+
describe Network, exclude: {version: 'beta'},
2525
exclusive: {bidi: true, reason: 'only executed when bidi is enabled'},
2626
only: {browser: %i[chrome edge firefox]} do
2727
let(:username) { SpecSupport::RackServer::TestApp::BASIC_AUTH_CREDENTIALS.first }

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

Lines changed: 1 addition & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ def browser
5858
end
5959

6060
def browser_version
61-
driver_instance.capabilities.browser_version
61+
ENV.fetch('WD_BROWSER_VERSION', 'stable')
6262
end
6363

6464
def driver_instance(...)
@@ -193,18 +193,6 @@ def create_driver!(listener: nil, **, &block)
193193
raise e
194194
end
195195

196-
def beta_chrome_version
197-
chrome_beta_url = 'https://chromereleases.googleblog.com/search/label/Beta%20updates'
198-
199-
uri = URI.parse(chrome_beta_url)
200-
201-
response = Net::HTTP.get_response(uri)
202-
203-
return "Failed to fetch Chrome Beta page: #{response&.code}" unless response.is_a?(Net::HTTPSuccess)
204-
205-
response.body.match(/\d+\.\d+\.\d+\.\d+/).to_s
206-
end
207-
208196
private
209197

210198
def build_options(**)

rb/spec/tests.bzl

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -111,6 +111,7 @@ BROWSERS = {
111111
"env": {
112112
"WD_REMOTE_BROWSER": "firefox",
113113
"WD_SPEC_DRIVER": "firefox",
114+
"WD_BROWSER_VERSION": "beta",
114115
} | select({
115116
"@selenium//common:use_pinned_linux_firefox": {
116117
"FIREFOX_BINARY": "$(location @linux_beta_firefox//:firefox/firefox)",

0 commit comments

Comments
 (0)