Skip to content

Commit 1e8366d

Browse files
committed
Add guard for beta chrome
1 parent f0e6b29 commit 1e8366d

File tree

1 file changed

+8
-8
lines changed

1 file changed

+8
-8
lines changed

rb/spec/integration/selenium/webdriver/spec_support/test_environment.rb

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -166,9 +166,13 @@ def root
166166
def create_driver!(listener: nil, **opts, &block)
167167
check_for_previous_error
168168

169-
chrome_beta(opts) if driver == :chrome_beta
169+
if driver == :chrome_beta
170+
opts[:browser_version] = 'beta'
171+
method = :chrome_driver
172+
else
173+
method = driver
174+
end
170175

171-
method = :"#{driver}_driver"
172176
instance = if private_methods.include?(method)
173177
send(method, listener: listener, options: build_options(**opts))
174178
else
@@ -197,7 +201,8 @@ def build_options(**opts)
197201
if private_methods.include?(options_method)
198202
send(options_method, **opts)
199203
else
200-
WebDriver::Options.send(browser, **opts)
204+
parsed_browser = browser == :chrome_beta ? :chrome : browser
205+
WebDriver::Options.send(parsed_browser, **opts)
201206
end
202207
end
203208

@@ -315,11 +320,6 @@ def random_port
315320
ensure
316321
sock.close
317322
end
318-
319-
def chrome_beta(opts = {})
320-
@driver = :chrome
321-
opts[:browser_version] = 'beta'
322-
end
323323
end
324324
end # SpecSupport
325325
end # WebDriver

0 commit comments

Comments
 (0)