Merge branch 'trunk' into refactor/typed-find-by-builder

Author: diemol

.bazelrc

@@ -24,10 +24,10 @@ build --flag_alias=headless=//common:headless
 
 # Set the default java toolchain
 
-build --java_language_version=17
-build --java_runtime_version=remotejdk_17
-build --tool_java_language_version=17
-build --tool_java_runtime_version=remotejdk_17
+build --java_language_version=21
+build --java_runtime_version=remotejdk_21
+build --tool_java_language_version=21
+build --tool_java_runtime_version=remotejdk_21
 
 # We target java 11 by default
 

.bazelrc.remote

@@ -31,7 +31,7 @@ build:rbe --disk_cache=
 build:rbe --incompatible_enable_cc_toolchain_resolution
 build:rbe --action_env=BAZEL_DO_NOT_DETECT_CPP_TOOLCHAIN=1
 test:rbe --test_env=DISPLAY=:99.0
-test:rbe --test_tag_filters=-exclusive-if-local,-skip-rbe,-remote
+test:rbe --test_tag_filters=-skip-rbe,-remote
 
 # Env vars we can hard code
 build:rbe --action_env=HOME=/home/dev

.github/ISSUE_TEMPLATE/bug-report.yml

@@ -35,21 +35,22 @@ body:
       label: Debugging Logs
       placeholder: |
         Note: the stack trace should be in the explanation section above
-        Instructions for enabling logging can be found in the link below
+        Instructions for enabling and referencing logs can be found in the links below
       render: logs
   - type: markdown
     id: link
     attributes:
       value: |
         **Read our [logging documentation](https://www.selenium.dev/documentation/webdriver/troubleshooting/logging/)**
+        **Link to a [gist](https://gist.github.com/) if logs are too long**
          
 
         ## Help us Address Your Issue Faster!
   - type: input
     id: selenium-version
     attributes:
       label: What version of Selenium are you currently using?
-      description: Important! The latest released version of Selenium is 4.30 and we can't fix old versions.
+      description: Important! The latest released version of Selenium is 4.34 and we can't fix old versions.
       placeholder: e.g., 4.17.0
     validations:
       required: true

.github/label-commenter-config.yml

@@ -6,36 +6,7 @@ labels:
         body: |
           @{{ issue.user.login }}, thank you for creating this issue. We will troubleshoot it as soon as we can.
 
-          ---
-          <details>
-            <summary>Info for maintainers</summary>
-            <div>
-              <br>
-              <p>
-                Triage this issue by using labels.
-              </p>
-              <p>
-                If information is missing, add a helpful comment and then <code>J-issue-template</code> label.
-              </p>
-              <p>
-                If the issue is a question, add the <code>I-question</code> label.
-              </p>
-              <p>
-                If the issue is valid but there is no time to troubleshoot it, consider adding the <code>help wanted</code> label.
-              </p>
-              <p>
-                If the issue requires changes or fixes from an external project (e.g., ChromeDriver, GeckoDriver, MSEdgeDriver, W3C),
-               add the applicable <code>G-*</code> label, and it will provide the correct link and auto-close the
-               issue.
-              </p>
-              <p>
-                After troubleshooting the issue, please add the <code>R-awaiting answer</code> label.
-              </p>
-              <p>
-                Thank you!
-              </p>
-            </div>
-          </details>
+          Selenium Triage Team: remember to follow the [Triage Guide](https://github.com/SeleniumHQ/selenium/wiki/How-to-Triage-Issues)
   - name: G-w3c
     labeled:
       issue:
@@ -122,14 +93,14 @@ labels:
           * 📮 [StackOverflow](https://stackoverflow.com/questions/tagged/selenium)
           * 🗣 Our [IRC/Slack/Matrix channels](https://www.selenium.dev/support/) where the community can help you as well
         action: close
-  - name: help wanted
+  - name: R-help wanted
     labeled:
       issue:
         body: |
           This issue is looking for contributors.
 
           Please comment below or reach out to us through our [IRC/Slack/Matrix channels](https://www.selenium.dev/support/) if you are interested.
-  - name: I-logging
+  - name: J-logging
     labeled:
       issue:
         body: |

.github/workflows/bazel.yml

@@ -122,7 +122,7 @@ jobs:
           node-version: ${{ inputs.node-version }}
       - name: Setup Bazel with caching
         if: inputs.caching
-        uses: bazel-contrib/setup-bazel@0.13.0
+        uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelisk-cache: true
           bazelrc: common --color=yes
@@ -136,7 +136,7 @@ jobs:
           repository-cache: true
       - name: Setup Bazel without caching
         if: inputs.caching == false
-        uses: bazel-contrib/setup-bazel@0.13.0
+        uses: bazel-contrib/setup-bazel@0.15.0
         with:
           bazelrc: common --color=yes
       - name: Setup curl for Ubuntu

.github/workflows/ci-grid-ui.yml

@@ -0,0 +1,38 @@
+name: CI - Grid UI
+
+on:
+  pull_request:
+    paths:
+      - 'javascript/grid-ui/**'
+  push:
+    branches:
+      - trunk
+    paths:
+      - 'javascript/grid-ui/**'
+  workflow_dispatch:
+  workflow_call:
+
+jobs:
+  grid-ui-tests:
+    runs-on: ubuntu-latest
+    name: Grid UI Component Tests
+    steps:
+      - name: Checkout source tree
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: 50
+
+      - name: Setup Node.js
+        uses: actions/setup-node@v4
+        with:
+          node-version: '20'
+          cache: 'npm'
+          cache-dependency-path: 'javascript/grid-ui/package.json'
+
+      - name: Install dependencies
+        working-directory: javascript/grid-ui
+        run: npm install
+
+      - name: Run component tests
+        working-directory: javascript/grid-ui
+        run: npm test

.github/workflows/ci-java.yml

@@ -23,7 +23,7 @@ jobs:
       java-version: 17
       run: |
         fsutil 8dot3name set 0
-        bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest `
+        bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest `
             //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest `
             //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest `
             //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest `
@@ -47,7 +47,7 @@ jobs:
       # https://github.com/bazelbuild/rules_jvm_external/issues/1046
       java-version: 17
       run: |
-        bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote \
+        bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote \
             //java/test/org/openqa/selenium/federatedcredentialmanagement:FederatedCredentialManagementTest \
           //java/test/org/openqa/selenium/firefox:FirefoxDriverBuilderTest \
             //java/test/org/openqa/selenium/grid/router:RemoteWebDriverDownloadTest \
@@ -71,4 +71,4 @@ jobs:
       # https://github.com/bazelbuild/rules_jvm_external/issues/1046
       java-version: 17
       run: |
-        bazel test --flaky_test_attempts 3 //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote
+        bazel test --flaky_test_attempts 3 --pin_browsers=true //java/test/org/openqa/selenium/chrome:ChromeDriverFunctionalTest-remote

.github/workflows/ci-python.yml

@@ -27,34 +27,12 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install tox==4.6.4
-      - name: Test with tox
+          pip install tox==4.27.0
+      - name: Generate docs
         run: tox -c py/tox.ini
         env:
           TOXENV: docs
 
-  lint:
-    name: Lint
-    needs: build
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout source tree
-        uses: actions/checkout@v4
-      - name: Set up Python 3.9
-        uses: actions/setup-python@v4
-        with:
-          python-version: 3.9
-      - name: Install dependencies
-        run: |
-          python -m pip install --upgrade pip
-          pip install tox==4.6.4
-      - name: Test with tox
-        run: tox -c py/tox.ini
-        env:
-          # If this fails, it will exit. Local work should be using `tox -e linting` prior to committing.
-          # the linting-ci recipe exists solely for CI and will not attempt to rewrite any files in-place etc.
-          TOXENV: linting-ci
-
   mypy:
     name: Mypy
     needs: build
@@ -69,11 +47,10 @@ jobs:
       - name: Install dependencies
         run: |
           python -m pip install --upgrade pip
-          pip install tox==4.6.4
-      - name: Test with tox
+          pip install tox==4.27.0
+      - name: Run type checking
         run: |
-          tox -c py/tox.ini -- --cobertura-xml-report ci || true
-          bash <(curl -s https://codecov.io/bash) -f py/ci/cobertura.xml
+          tox -c py/tox.ini || true
         env:
           TOXENV: mypy
 
@@ -112,8 +89,8 @@ jobs:
       os: ${{ matrix.os }}
       cache-key: py-browser-${{ matrix.browser }}
       run: |
-        bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:common-${{ matrix.browser }}-bidi
-        bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }}
+        bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:common-${{ matrix.browser }}-bidi
+        bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:test-${{ matrix.browser }}
 
   safari-tests:
     name: Browser Tests
@@ -131,4 +108,4 @@ jobs:
       os: ${{ matrix.os }}
       cache-key: py-browser-${{ matrix.browser }}
       run: |
-        bazel test --local_test_jobs 1 --flaky_test_attempts 3 //py:test-${{ matrix.browser }}
+        bazel test --local_test_jobs 1 --flaky_test_attempts 3 --pin_browsers=true //py:test-${{ matrix.browser }}

.github/workflows/ci-rbe.yml

@@ -6,6 +6,12 @@ on:
     branches:
       - trunk
   workflow_dispatch:
+    inputs:
+      disable_test_cache:
+        description: 'Force re-run of tests (disable test cache)'
+        required: false
+        default: false
+        type: boolean
 
 jobs:
   format:
@@ -15,7 +21,7 @@ jobs:
     with:
       name: Check format script run
       caching: false
-      ruby-version: jruby-9.4.12.0
+      ruby-version: jruby-10.0.0.0
       run: ./scripts/github-actions/check-format.sh
 
   test:
@@ -25,5 +31,5 @@ jobs:
     with:
       name: All RBE tests
       caching: false
-      ruby-version: jruby-9.4.12.0
-      run: ./scripts/github-actions/ci-build.sh
+      ruby-version: jruby-10.0.0.0
+      run: ./scripts/github-actions/ci-build.sh ${{ github.event.inputs.disable_test_cache }}

.github/workflows/ci-renovate-rbe.yml

@@ -47,7 +47,7 @@ jobs:
     with:
       name: Check format script run
       caching: false
-      ruby-version: jruby-9.4.12.0
+      ruby-version: jruby-10.0.0.0
       run: ./scripts/github-actions/check-format.sh
 
   test:
@@ -58,7 +58,7 @@ jobs:
     with:
       name: All RBE tests
       caching: false
-      ruby-version: jruby-9.4.12.0
+      ruby-version: jruby-10.0.0.0
       run: ./scripts/github-actions/ci-build.sh
 
   ci-gh: