Skip to content

Commit 2114724

Browse files
committed
validate and set the url directly from bridge constructor
1 parent 343d32b commit 2114724

File tree

1 file changed

+5
-3
lines changed

1 file changed

+5
-3
lines changed

rb/lib/selenium/webdriver/remote/bridge.rb

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -63,7 +63,9 @@ def initialize(url: nil, http_client: nil, client_config: nil)
6363
raise Error::WebDriverError, 'Cannot specify both http_client and client_config'
6464
end
6565

66-
@http = http_client || create_http_client(client_config, url: url)
66+
@http = http_client || build_http_client(client_config)
67+
validate_server_url_args(url, client_config)
68+
@http.server_url = normalize_url(url || client_config&.server_url)
6769

6870
@file_detector = nil
6971
@locator_converter = self.class.locator_converter
@@ -90,12 +92,12 @@ def create_session(capabilities)
9092
extend(WebDriver::Firefox::Features)
9193
when 'msedge', 'MicrosoftEdge'
9294
extend(WebDriver::Edge::Features)
93-
when 'Safari', 'Safari Technology Preview'
95+
when 'safari', 'Safari', 'Safari Technology Preview'
9496
extend(WebDriver::Safari::Features)
9597
when 'internet explorer'
9698
extend(WebDriver::IE::Features)
9799
else
98-
raise Error::WebDriverError, "Unknown browser name: #{@capabilities[:browser_name]}"
100+
WebDriver.logger.info "Unknown browser: #{capabilities[:browser_name]}", id: :session
99101
end
100102
end
101103

0 commit comments

Comments
 (0)