Skip to content

Commit 24e04b6

Browse files
authored
Merge branch 'trunk' into py-client-config
2 parents 2657eed + d411615 commit 24e04b6

File tree

4 files changed

+96
-70
lines changed

4 files changed

+96
-70
lines changed

java/test/org/openqa/selenium/edge/EdgeDriverFunctionalTest.java

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -116,20 +116,20 @@ void canSetPermission() {
116116
@NoDriverBeforeTest
117117
public void canSetPermissionHeadless() {
118118
EdgeOptions options = new EdgeOptions();
119-
options.addArguments("--headless=chrome");
119+
options.addArguments("--headless=new");
120120

121121
localDriver = new WebDriverBuilder().get(options);
122122
HasPermissions permissions = (HasPermissions) localDriver;
123123

124124
localDriver.get(pages.clicksPage);
125125
assertThat(checkPermission(localDriver, CLIPBOARD_READ)).isEqualTo("prompt");
126-
assertThat(checkPermission(localDriver, CLIPBOARD_WRITE)).isEqualTo("prompt");
126+
assertThat(checkPermission(localDriver, CLIPBOARD_WRITE)).isEqualTo("granted");
127127

128128
permissions.setPermission(CLIPBOARD_READ, "granted");
129-
permissions.setPermission(CLIPBOARD_WRITE, "granted");
129+
permissions.setPermission(CLIPBOARD_WRITE, "prompt");
130130

131131
assertThat(checkPermission(localDriver, CLIPBOARD_READ)).isEqualTo("granted");
132-
assertThat(checkPermission(localDriver, CLIPBOARD_WRITE)).isEqualTo("granted");
132+
assertThat(checkPermission(localDriver, CLIPBOARD_WRITE)).isEqualTo("prompt");
133133
}
134134

135135
public String checkPermission(WebDriver driver, String permission) {

java/test/org/openqa/selenium/grid/router/RemoteWebDriverDownloadTest.java

Lines changed: 24 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,6 +30,7 @@
3030
import java.util.LinkedList;
3131
import java.util.List;
3232
import java.util.Objects;
33+
import java.util.Set;
3334
import java.util.concurrent.ExecutorService;
3435
import java.util.concurrent.Executors;
3536
import org.junit.jupiter.api.AfterEach;
@@ -57,6 +58,8 @@
5758

5859
class RemoteWebDriverDownloadTest {
5960

61+
private static final Set<String> FILE_EXTENSIONS = Set.of(".txt", ".jpg");
62+
6063
private Server<?> server;
6164
private NettyAppServer appServer;
6265
private Capabilities capabilities;
@@ -112,7 +115,15 @@ void canListDownloadedFiles() {
112115
driver.findElement(By.id("file-2")).click();
113116

114117
new WebDriverWait(driver, Duration.ofSeconds(5))
115-
.until(d -> ((HasDownloads) d).getDownloadableFiles().size() == 2);
118+
.until(
119+
d ->
120+
((HasDownloads) d)
121+
.getDownloadableFiles().stream()
122+
// ensure we hit no temporary file created by the browser while
123+
// downloading
124+
.filter((f) -> FILE_EXTENSIONS.stream().anyMatch(f::endsWith))
125+
.count()
126+
== 2);
116127

117128
List<String> downloadableFiles = ((HasDownloads) driver).getDownloadableFiles();
118129
assertThat(downloadableFiles).contains("file_1.txt", "file_2.jpg");
@@ -132,7 +143,12 @@ void canDownloadFiles() throws IOException {
132143
driver.findElement(By.id("file-1")).click();
133144

134145
new WebDriverWait(driver, Duration.ofSeconds(5))
135-
.until(d -> !((HasDownloads) d).getDownloadableFiles().isEmpty());
146+
.until(
147+
d ->
148+
((HasDownloads) d)
149+
.getDownloadableFiles().stream()
150+
// ensure we hit no temporary file created by the browser while downloading
151+
.anyMatch((f) -> FILE_EXTENSIONS.stream().anyMatch(f::endsWith)));
136152

137153
String fileName = ((HasDownloads) driver).getDownloadableFiles().get(0);
138154

@@ -155,7 +171,12 @@ void testCanDeleteFiles() {
155171
driver.findElement(By.id("file-1")).click();
156172

157173
new WebDriverWait(driver, Duration.ofSeconds(5))
158-
.until(d -> !((HasDownloads) d).getDownloadableFiles().isEmpty());
174+
.until(
175+
d ->
176+
((HasDownloads) d)
177+
.getDownloadableFiles().stream()
178+
// ensure we hit no temporary file created by the browser while downloading
179+
.anyMatch((f) -> FILE_EXTENSIONS.stream().anyMatch(f::endsWith)));
159180

160181
driver = new Augmenter().augment(driver);
161182
((HasDownloads) driver).deleteDownloadableFiles();

javascript/node/selenium-webdriver/package.json

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -29,19 +29,19 @@
2929
"ws": "^8.18.0"
3030
},
3131
"devDependencies": {
32-
"@eslint/js": "^9.13.0",
32+
"@eslint/js": "^9.14.0",
3333
"clean-jsdoc-theme": "^4.3.0",
34-
"eslint": "^9.13.0",
34+
"eslint": "^9.14.0",
3535
"eslint-config-prettier": "^9.1.0",
3636
"eslint-plugin-mocha": "^10.5.0",
37-
"eslint-plugin-n": "^17.11.1",
37+
"eslint-plugin-n": "^17.13.1",
3838
"eslint-plugin-no-only-tests": "^3.3.0",
3939
"eslint-plugin-prettier": "^5.2.1",
4040
"express": "^4.21.1",
41-
"globals": "^15.11.0",
41+
"globals": "^15.12.0",
4242
"has-flag": "^5.0.1",
4343
"jsdoc": "^4.0.4",
44-
"mocha": "^10.7.3",
44+
"mocha": "^10.8.2",
4545
"mocha-junit-reporter": "^2.2.1",
4646
"multer": "1.4.5-lts.1",
4747
"prettier": "^3.3.3",

0 commit comments

Comments
 (0)