Skip to content

Commit 24fb5ae

Browse files
committed
[py] Fix proxy basic auth handling special characters
1 parent ef6c472 commit 24fb5ae

File tree

1 file changed

+4
-2
lines changed

1 file changed

+4
-2
lines changed

py/selenium/webdriver/remote/remote_connection.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@
2222
from base64 import b64encode
2323
from typing import Optional
2424
from urllib import parse
25-
from urllib.parse import urlparse
25+
from urllib.parse import unquote, urlparse
2626

2727
import urllib3
2828

@@ -298,7 +298,9 @@ def _get_connection_manager(self):
298298
return SOCKSProxyManager(self._proxy_url, **pool_manager_init_args)
299299
if self._identify_http_proxy_auth():
300300
self._proxy_url, self._basic_proxy_auth = self._separate_http_proxy_auth()
301-
pool_manager_init_args["proxy_headers"] = urllib3.make_headers(proxy_basic_auth=self._basic_proxy_auth)
301+
pool_manager_init_args["proxy_headers"] = urllib3.make_headers(
302+
proxy_basic_auth=unquote(self._basic_proxy_auth)
303+
)
302304
return urllib3.ProxyManager(self._proxy_url, **pool_manager_init_args)
303305

304306
return urllib3.PoolManager(**pool_manager_init_args)

0 commit comments

Comments
 (0)