Skip to content

Commit 25c8376

Browse files
Refactor ChromeDriverFunctionalTest: (#14398)
Refactor ChromeDriverFunctionalTest: Remove redundant permission constants Removed the CLIPBOARD_READ and CLIPBOARD_WRITE constants from the class level in ChromeDriverFunctionalTest to avoid redundancy. These constants are now defined within the canSetPermission method, reducing unnecessary visibility and improving code cohesion. This change simplifies maintenance and enhances code clarity without altering existing functionality. Co-authored-by: Diego Molina <[email protected]>
1 parent d8a7172 commit 25c8376

File tree

1 file changed

+2
-3
lines changed

1 file changed

+2
-3
lines changed

java/test/org/openqa/selenium/chrome/ChromeDriverFunctionalTest.java

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -50,9 +50,6 @@
5050

5151
class ChromeDriverFunctionalTest extends JupiterTestBase {
5252

53-
private final String CLIPBOARD_READ = "clipboard-read";
54-
private final String CLIPBOARD_WRITE = "clipboard-write";
55-
5653
@Test
5754
@NoDriverBeforeTest
5855
public void builderGeneratesDefaultChromeOptions() {
@@ -109,7 +106,9 @@ void canSetPermission() {
109106
HasPermissions permissions = (HasPermissions) driver;
110107

111108
driver.get(pages.clicksPage);
109+
String CLIPBOARD_READ = "clipboard-read";
112110
assumeThat(checkPermission(driver, CLIPBOARD_READ)).isEqualTo("prompt");
111+
String CLIPBOARD_WRITE = "clipboard-write";
113112
assumeThat(checkPermission(driver, CLIPBOARD_WRITE)).isEqualTo("granted");
114113

115114
permissions.setPermission(CLIPBOARD_READ, "denied");

0 commit comments

Comments
 (0)