avoid establishing CDP connection in maybeGet*() method

1. method `getBiDi`/`getDevTools` should establish a connection, BUT
1. method `maybeGet*()` returns connection only if the connection is already established, but should NOT establish a new connection.

It's because method `maybeGet*()` is used from `WebDriver.close()` and `WebDriver.quite()`. At this moment, we don't want a new connection, we only want to close the existing connection.

Author: asolntsev

java/src/org/openqa/selenium/bidi/BiDiProvider.java

@@ -22,6 +22,7 @@
 import java.net.URISyntaxException;
 import java.util.Optional;
 import java.util.function.Predicate;
+
 import org.openqa.selenium.Capabilities;
 import org.openqa.selenium.remote.AugmenterProvider;
 import org.openqa.selenium.remote.ExecuteMethod;
@@ -45,22 +46,28 @@ public Class<HasBiDi> getDescribedInterface() {
   @Override
   public HasBiDi getImplementation(Capabilities caps, ExecuteMethod executeMethod) {
     return new HasBiDi() {
-      private volatile Optional<BiDi> biDi;
+      private volatile BiDi biDi;
+      private final Object lock = new Object();
 
       @Override
       public Optional<BiDi> maybeGetBiDi() {
+        return Optional.ofNullable(biDi);
+      }
+
+      @Override
+      public BiDi getBiDi() {
         if (biDi == null) {
-          synchronized (this) {
+          synchronized (lock) {
             if (biDi == null) {
               URI wsUri =
-                  getBiDiUrl(caps).orElseThrow(() -> new BiDiException("BiDi not supported"));
+                getBiDiUrl(caps).orElseThrow(() -> new BiDiException("BiDi not supported"));
 
               HttpClient.Factory clientFactory = HttpClient.Factory.createDefault();
               ClientConfig wsConfig = ClientConfig.defaultConfig().baseUri(wsUri);
               HttpClient wsClient = clientFactory.createClient(wsConfig);
               Connection connection = new Connection(wsClient, wsUri.toString());
 
-              biDi = Optional.of(new BiDi(connection));
+              biDi = new BiDi(connection);
             }
           }
         }

java/src/org/openqa/selenium/devtools/DevToolsProvider.java

@@ -21,6 +21,7 @@
 import java.net.URI;
 import java.util.Optional;
 import java.util.function.Predicate;
+
 import org.openqa.selenium.Capabilities;
 import org.openqa.selenium.devtools.noop.NoOpCdpInfo;
 import org.openqa.selenium.remote.AugmenterProvider;
@@ -43,21 +44,28 @@ public Class<HasDevTools> getDescribedInterface() {
   @Override
   public HasDevTools getImplementation(Capabilities caps, ExecuteMethod executeMethod) {
     return new HasDevTools() {
-      private volatile Optional<DevTools> devTools;
+      private volatile DevTools devTools;
+      private final Object lock = new Object();
 
       @Override
       public Optional<DevTools> maybeGetDevTools() {
+        return Optional.ofNullable(devTools);
+      }
+
+      @Override
+      public DevTools getDevTools() {
         if (devTools == null) {
-          synchronized (this) {
+          synchronized (lock) {
             if (devTools == null) {
               Object cdpVersion = caps.getCapability("se:cdpVersion");
               String version =
-                  cdpVersion instanceof String ? (String) cdpVersion : caps.getBrowserVersion();
+                cdpVersion instanceof String ? (String) cdpVersion : caps.getBrowserVersion();
 
               CdpInfo info = new CdpVersionFinder().match(version).orElseGet(NoOpCdpInfo::new);
               this.devTools =
-                  SeleniumCdpConnection.create(caps)
-                      .map(conn -> new DevTools(info::getDomains, conn));
+                SeleniumCdpConnection.create(caps)
+                  .map(conn -> new DevTools(info::getDomains, conn))
+                  .orElseThrow(() -> new DevToolsException("Unable to create DevTools connection"));
             }
           }
         }