Skip to content

Commit 2a8261d

Browse files
authored
[py] Remove old test xfail markers (#16377)
1 parent 565459e commit 2a8261d

File tree

3 files changed

+4
-13
lines changed

3 files changed

+4
-13
lines changed

py/test/selenium/webdriver/common/alerts_tests.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -157,8 +157,8 @@ def test_alert_should_not_allow_additional_commands_if_dimissed(driver, pages):
157157
alert.text
158158

159159

160-
@pytest.mark.xfail_firefox(reason="Fails on travis")
161-
@pytest.mark.xfail_remote(reason="Fails on travis")
160+
@pytest.mark.xfail_firefox
161+
@pytest.mark.xfail_remote
162162
@pytest.mark.xfail_safari
163163
def test_should_allow_users_to_accept_an_alert_in_aframe(driver, pages):
164164
pages.load("alerts.html")
@@ -171,8 +171,8 @@ def test_should_allow_users_to_accept_an_alert_in_aframe(driver, pages):
171171
assert "Testing Alerts" == driver.title
172172

173173

174-
@pytest.mark.xfail_firefox(reason="Fails on travis")
175-
@pytest.mark.xfail_remote(reason="Fails on travis")
174+
@pytest.mark.xfail_firefox
175+
@pytest.mark.xfail_remote
176176
@pytest.mark.xfail_safari
177177
def test_should_allow_users_to_accept_an_alert_in_anested_frame(driver, pages):
178178
pages.load("alerts.html")

py/test/selenium/webdriver/common/w3c_interaction_tests.py

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -146,8 +146,6 @@ def test_context_click(driver, pages):
146146

147147
@pytest.mark.xfail_firefox
148148
@pytest.mark.xfail_safari
149-
@pytest.mark.xfail_remote(reason="Fails on Travis")
150-
@pytest.mark.xfail_chrome(reason="Fails on Travis")
151149
def test_double_click(driver, pages):
152150
"""Copied from org.openqa.selenium.interactions.TestBasicMouseInterface."""
153151
pages.load("javascriptPage.html")

py/test/selenium/webdriver/common/window_tests.py

Lines changed: 0 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -21,9 +21,6 @@
2121
from selenium.webdriver.support.wait import WebDriverWait
2222

2323
# @pytest.mark.xfail_ie
24-
# @pytest.mark.xfail_edge(reason="Fails on Travis")
25-
# @pytest.mark.xfail_firefox(reason="Fails on Travis")
26-
# @pytest.mark.xfail_remote(reason="Fails on Travis")
2724
# def test_should_maximize_the_window(driver):
2825
# resize_timeout = 5
2926
# wait = WebDriverWait(driver, resize_timeout)
@@ -138,8 +135,6 @@ def test_set_window_rect_throws_when_height_and_width_are_0(driver):
138135

139136
# @pytest.mark.xfail_safari(raises=WebDriverException,
140137
# reason='Fullscreen command not implemented')
141-
# @pytest.mark.skipif(os.environ.get('TRAVIS') == 'true',
142-
# reason='Fullscreen command causes Travis to hang')
143138
# @pytest.mark.no_driver_after_test
144139
# def test_should_fullscreen_the_current_window(driver):
145140
# start_width = driver.execute_script('return window.innerWidth;')
@@ -161,8 +156,6 @@ def test_set_window_rect_throws_when_height_and_width_are_0(driver):
161156

162157
# @pytest.mark.xfail_safari(raises=WebDriverException,
163158
# reason='Minimize command not implemented')
164-
# @pytest.mark.skipif(os.environ.get('TRAVIS') == 'true',
165-
# reason='Minimize command causes Travis to hang')
166159
# @pytest.mark.no_driver_after_test
167160
# def test_should_minimize_the_current_window(driver):
168161
# driver.minimize_window()

0 commit comments

Comments
 (0)