Skip to content

Commit 2be9609

Browse files
authored
[dotnet] [bidi] Decouple ChannelProperties in Script module (#15489)
1 parent a44134b commit 2be9609

File tree

2 files changed

+28
-8
lines changed

2 files changed

+28
-8
lines changed
Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,27 @@
1+
// <copyright file="ChannelProperties.cs" company="Selenium Committers">
2+
// Licensed to the Software Freedom Conservancy (SFC) under one
3+
// or more contributor license agreements. See the NOTICE file
4+
// distributed with this work for additional information
5+
// regarding copyright ownership. The SFC licenses this file
6+
// to you under the Apache License, Version 2.0 (the
7+
// "License"); you may not use this file except in compliance
8+
// with the License. You may obtain a copy of the License at
9+
//
10+
// http://www.apache.org/licenses/LICENSE-2.0
11+
//
12+
// Unless required by applicable law or agreed to in writing,
13+
// software distributed under the License is distributed on an
14+
// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
15+
// KIND, either express or implied. See the License for the
16+
// specific language governing permissions and limitations
17+
// under the License.
18+
// </copyright>
19+
20+
namespace OpenQA.Selenium.BiDi.Modules.Script;
21+
22+
public record ChannelProperties(Channel Channel)
23+
{
24+
public SerializationOptions? SerializationOptions { get; set; }
25+
26+
public ResultOwnership? Ownership { get; set; }
27+
}

dotnet/src/webdriver/BiDi/Modules/Script/LocalValue.cs

Lines changed: 1 addition & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -90,18 +90,11 @@ public record BooleanLocalValue(bool Value) : PrimitiveProtocolLocalValue;
9090

9191
public record BigIntLocalValue(string Value) : PrimitiveProtocolLocalValue;
9292

93-
public record ChannelLocalValue(ChannelLocalValue.ChannelProperties Value) : LocalValue
93+
public record ChannelLocalValue(ChannelProperties Value) : LocalValue
9494
{
9595
// TODO: Revise why we need it
9696
[JsonInclude]
9797
internal string type = "channel";
98-
99-
public record ChannelProperties(Channel Channel)
100-
{
101-
public SerializationOptions? SerializationOptions { get; set; }
102-
103-
public ResultOwnership? Ownership { get; set; }
104-
}
10598
}
10699

107100
public record ArrayLocalValue(IEnumerable<LocalValue> Value) : LocalValue;

0 commit comments

Comments
 (0)