Skip to content

Commit 2c9b3c3

Browse files
committed
[grid]: Distributor could not get session timeout from RemoteNode status
Signed-off-by: Viet Nguyen Duc <[email protected]>
1 parent 2cc7a5b commit 2c9b3c3

File tree

4 files changed

+11
-1
lines changed

4 files changed

+11
-1
lines changed

java/src/org/openqa/selenium/grid/graphql/Grid.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -97,6 +97,7 @@ public List<Node> getNodes() {
9797
status.getExternalUri(),
9898
status.getAvailability(),
9999
status.getMaxSessionCount(),
100+
status.getSessionTimeout(),
100101
status.getSlots().size(),
101102
stereotypes,
102103
sessions,

java/src/org/openqa/selenium/grid/graphql/Node.java

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@
1919

2020
import com.google.common.collect.ImmutableList;
2121
import java.net.URI;
22+
import java.time.Duration;
2223
import java.util.ArrayList;
2324
import java.util.HashMap;
2425
import java.util.List;
@@ -43,12 +44,14 @@ public class Node {
4344
private final String version;
4445
private final OsInfo osInfo;
4546
private final int slotCount;
47+
private final Duration sessionTimeout;
4648

4749
public Node(
4850
NodeId id,
4951
URI uri,
5052
Availability status,
5153
int maxSession,
54+
Duration sessionTimeout,
5255
int slotCount,
5356
Map<Capabilities, Integer> stereotypes,
5457
Map<Session, Slot> activeSessions,
@@ -63,6 +66,7 @@ public Node(
6366
this.activeSessions = Require.nonNull("Active sessions", activeSessions);
6467
this.version = Require.nonNull("Grid Node version", version);
6568
this.osInfo = Require.nonNull("Grid Node OS info", osInfo);
69+
this.sessionTimeout = Require.nonNull("Grid Node session timeout", sessionTimeout);
6670
}
6771

6872
public List<org.openqa.selenium.grid.graphql.Session> getSessions() {
@@ -122,6 +126,10 @@ public OsInfo getOsInfo() {
122126
return osInfo;
123127
}
124128

129+
public Duration getSessionTimeout() {
130+
return sessionTimeout;
131+
}
132+
125133
private org.openqa.selenium.grid.graphql.Session createGraphqlSession(
126134
Map.Entry<Session, Slot> entry) {
127135
Session session = entry.getKey();

java/src/org/openqa/selenium/grid/node/Node.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ protected Node(
126126
this.tracer = Require.nonNull("Tracer", tracer);
127127
this.id = Require.nonNull("Node id", id);
128128
this.uri = Require.nonNull("URI", uri);
129-
this.sessionTimeout = Require.positive("Session timeout", sessionTimeout);
129+
this.sessionTimeout = Require.nonNull("Node session timeout", sessionTimeout);
130130
Require.nonNull("Registration secret", registrationSecret);
131131

132132
RequiresSecretFilter requiresSecret = new RequiresSecretFilter(registrationSecret);

java/src/org/openqa/selenium/grid/router/GridStatusHandler.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -141,6 +141,7 @@ public HttpResponse execute(HttpRequest req) {
141141
.put("id", node.getNodeId())
142142
.put("uri", node.getExternalUri())
143143
.put("maxSessions", node.getMaxSessionCount())
144+
.put("sessionTimeout", node.getSessionTimeout().toMillis())
144145
.put("osInfo", node.getOsInfo())
145146
.put("heartbeatPeriod", node.getHeartbeatPeriod().toMillis())
146147
.put("availability", node.getAvailability())

0 commit comments

Comments
 (0)