Merge branch 'trunk' into ruby-pagesize-support

Author: yvsvarma

.bazelrc

@@ -8,7 +8,11 @@ try-import %workspace%/.bazelrc.windows.local
 # https://github.com/bazelbuild/bazel/issues/20369
 # https://github.com/bazelbuild/bazel/issues/21491
 
-common --enable_bzlmod --lockfile_mode=off
+common --lockfile_mode=off
+
+# Prepare for Bazel 8. These become the default in 8.0.0
+common --incompatible_disallow_empty_glob
+common --incompatible_use_plus_in_repo_names
 
 # Ensure Windows support is accurate.
 

dotnet/src/support/BUILD.bazel

@@ -31,7 +31,6 @@ csharp_library(
         "*.cs",
         "Events/*.cs",
         "Extensions/*.cs",
-        "PageObjects/**/*.cs",
         "UI/*.cs",
     ]) + [":assembly-info"],
     out = "WebDriver.Support",
@@ -71,7 +70,6 @@ csharp_library(
         "*.cs",
         "Events/*.cs",
         "Extensions/*.cs",
-        "PageObjects/**/*.cs",
         "UI/*.cs",
     ]) + [":assembly-info"],
     out = "WebDriver.Support.StrongNamed",

dotnet/src/webdriver/CapabilityType.cs

@@ -18,6 +18,9 @@
 // </copyright>
 
 using System.Collections.Generic;
+using System.Diagnostics.CodeAnalysis;
+
+#nullable enable
 
 namespace OpenQA.Selenium
 {
@@ -167,7 +170,8 @@ public static class CapabilityType
         /// </summary>
         public static readonly string EnableDownloads = "se:downloadsEnabled";
 
-        private static readonly List<string> KnownSpecCompliantCapabilityNames = new List<string>() {
+        private static readonly HashSet<string> KnownSpecCompliantCapabilityNames = new HashSet<string>()
+        {
             BrowserName,
             BrowserVersion,
             PlatformName,
@@ -188,8 +192,13 @@ public static class CapabilityType
         /// <param name="capabilityName">The name of the capability to check for compliance.</param>
         /// <returns><see langword="true"/> if the capability name is valid according to the rules
         /// of the specification; otherwise, <see langword="false"/>.</returns>
-        public static bool IsSpecCompliantCapabilityName(string capabilityName)
+        public static bool IsSpecCompliantCapabilityName([NotNullWhen(true)] string? capabilityName)
         {
+            if (capabilityName is null)
+            {
+                return false;
+            }
+
             if (KnownSpecCompliantCapabilityNames.Contains(capabilityName) || capabilityName.Contains(":"))
             {
                 return true;

dotnet/src/webdriver/CommandInfo.cs

@@ -19,6 +19,8 @@
 
 using System;
 
+#nullable enable
+
 namespace OpenQA.Selenium
 {
     /// <summary>
@@ -45,7 +47,7 @@ public override int GetHashCode()
         /// </summary>
         /// <param name="obj">The <see cref="CommandInfo"/> to compare to this instance.</param>
         /// <returns><see langword="true"/> if <paramref name="obj"/> is a <see cref="CommandInfo"/> and its value is the same as this instance; otherwise, <see langword="false"/>. If <paramref name="obj"/> is <see langword="null"/>, the method returns <see langword="false"/>.</returns>
-        public override bool Equals(object obj)
+        public override bool Equals(object? obj)
         {
             return this.Equals(obj as CommandInfo);
         }
@@ -55,15 +57,15 @@ public override bool Equals(object obj)
         /// </summary>
         /// <param name="other">The <see cref="CommandInfo"/> to compare to this instance.</param>
         /// <returns><see langword="true"/> if the value of the <paramref name="other"/> parameter is the same as this instance; otherwise, <see langword="false"/>. If <paramref name="other"/> is <see langword="null"/>, the method returns <see langword="false"/>.</returns>
-        public bool Equals(CommandInfo other)
+        public bool Equals(CommandInfo? other)
         {
             if (other is null)
             {
                 return false;
             }
 
             // Optimization for a common success case.
-            if (Object.ReferenceEquals(this, other))
+            if (object.ReferenceEquals(this, other))
             {
                 return true;
             }
@@ -86,7 +88,7 @@ public bool Equals(CommandInfo other)
         /// <param name="left">The first <see cref="CommandInfo"/> object to compare.</param>
         /// <param name="right">The second <see cref="CommandInfo"/> object to compare.</param>
         /// <returns><see langword="true"/> if the value of <paramref name="left"/> is the same as the value of <paramref name="right"/>; otherwise, <see langword="false"/>.</returns>
-        public static bool operator ==(CommandInfo left, CommandInfo right)
+        public static bool operator ==(CommandInfo? left, CommandInfo? right)
         {
             if (left is null)
             {
@@ -107,7 +109,7 @@ public bool Equals(CommandInfo other)
         /// <param name="left">The first <see cref="CommandInfo"/> object to compare.</param>
         /// <param name="right">The second <see cref="CommandInfo"/> object to compare.</param>
         /// <returns><see langword="true"/> if the value of <paramref name="left"/> is different from the value of <paramref name="right"/>; otherwise, <see langword="false"/>.</returns>
-        public static bool operator !=(CommandInfo left, CommandInfo right)
+        public static bool operator !=(CommandInfo? left, CommandInfo? right)
         {
             return !(left == right);
         }

dotnet/src/webdriver/DevTools/DevToolsExtensionMethods.cs

@@ -17,6 +17,8 @@
 // under the License.
 // </copyright>
 
+#nullable enable
+
 namespace OpenQA.Selenium.DevTools
 {
     /// <summary>

dotnet/src/webdriver/DevTools/DevToolsOptions.cs

@@ -17,6 +17,8 @@
 // under the License.
 // </copyright>
 
+#nullable enable
+
 namespace OpenQA.Selenium.DevTools
 {
     /// <summary>

dotnet/src/webdriver/DevTools/DevToolsSessionDomains.cs

@@ -17,15 +17,15 @@
 // under the License.
 // </copyright>
 
+#nullable enable
+
 namespace OpenQA.Selenium.DevTools
 {
     /// <summary>
     /// Provides an abstract base class for version-specific domain implementations.
     /// </summary>
     public abstract class DevToolsSessionDomains
     {
-        private CommandResponseTypeMap responseTypeMap = new CommandResponseTypeMap();
-
         /// <summary>
         /// Initializes a new instance of the <see cref="DevToolsSessionDomains"/> class.
         /// </summary>
@@ -37,7 +37,7 @@ protected DevToolsSessionDomains()
         /// <summary>
         /// Gets the <see cref="CommandResponseTypeMap"/> containing information about the types returned by DevTools Protocol commands.,
         /// </summary>
-        internal CommandResponseTypeMap ResponseTypeMap => this.responseTypeMap;
+        internal CommandResponseTypeMap ResponseTypeMap { get; } = new CommandResponseTypeMap();
 
         /// <summary>
         /// Populates the command response type map.

dotnet/src/webdriver/DevTools/DevToolsSessionEventReceivedEventArgs.cs

@@ -21,6 +21,8 @@
 using System.Text.Json;
 using System.Text.Json.Nodes;
 
+#nullable enable
+
 namespace OpenQA.Selenium.DevTools
 {
     /// <summary>
@@ -44,16 +46,16 @@ public DevToolsEventReceivedEventArgs(string domainName, string eventName, JsonE
         /// <summary>
         /// Gets the domain on which the event is to be raised.
         /// </summary>
-        public string DomainName { get; private set; }
+        public string DomainName { get; }
 
         /// <summary>
         /// Gets the name of the event to be raised.
         /// </summary>
-        public string EventName { get; private set; }
+        public string EventName { get; }
 
         /// <summary>
         /// Gets the data with which the event is to be raised.
         /// </summary>
-        public JsonElement EventData { get; private set; }
+        public JsonElement EventData { get; }
     }
 }

dotnet/src/webdriver/DevTools/DevToolsSessionLogMessageEventArgs.cs

@@ -19,6 +19,8 @@
 
 using System;
 
+#nullable enable
+
 namespace OpenQA.Selenium.DevTools
 {
     /// <summary>

dotnet/src/webdriver/DevTools/ExceptionThrownEventArgs.cs

@@ -19,21 +19,34 @@
 
 using System;
 
+#nullable enable
+
 namespace OpenQA.Selenium.DevTools
 {
     /// <summary>
     /// Provides data for events relating to JavaScript exception handling.
     /// </summary>
     public class ExceptionThrownEventArgs : EventArgs
     {
+        /// <summary>
+        /// Initializes new instance of the <see cref="ExceptionThrownEventArgs"/> type.
+        /// </summary>
+        /// <param name="timestamp">The time stamp of the exception.</param>
+        /// <param name="message">The text of the exception.</param>
+        public ExceptionThrownEventArgs(DateTime timestamp, string message)
+        {
+            Timestamp = timestamp;
+            Message = message;
+        }
+
         /// <summary>
         /// Gets the time stamp of the exception.
         /// </summary>
-        public DateTime Timestamp { get; internal set; }
+        public DateTime Timestamp { get; }
 
         /// <summary>
         /// Gets the text of the exception.
         /// </summary>
-        public string Message { get; internal set; }
+        public string Message { get; }
     }
 }