[java] Removing NullAway checks in JMXHelper as these are internal classes.

Author: diemol

java/src/org/openqa/selenium/grid/jmx/BUILD.bazel

@@ -1,4 +1,4 @@
-load("//java:defs.bzl", "artifact", "java_library")
+load("//java:defs.bzl", "java_library")
 
 java_library(
     name = "jmx",
@@ -8,7 +8,4 @@ java_library(
         "//java/src/org/openqa/selenium/grid/session:__pkg__",
         "//java/test/org/openqa/selenium/grid:__subpackages__",
     ],
-    deps = [
-        artifact("org.jspecify:jspecify"),
-    ],
 )

java/src/org/openqa/selenium/grid/jmx/JMXHelper.java

@@ -22,13 +22,12 @@
 import javax.management.InstanceAlreadyExistsException;
 import javax.management.MBeanServer;
 import javax.management.ObjectName;
-import org.jspecify.annotations.Nullable;
 
 public class JMXHelper {
 
   private static final Logger LOG = Logger.getLogger(JMXHelper.class.getName());
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   public MBean register(Object bean) {
     MBeanServer mbs = ManagementFactory.getPlatformMBeanServer();
     MBean mBean = new MBean(bean);

java/src/org/openqa/selenium/grid/jmx/MBean.java

@@ -34,7 +34,6 @@
 import javax.management.MBeanOperationInfo;
 import javax.management.MalformedObjectNameException;
 import javax.management.ObjectName;
-import org.jspecify.annotations.Nullable;
 
 public class MBean implements DynamicMBean {
 
@@ -58,7 +57,7 @@ private static class AttributeInfo {
       this.setter = setter;
     }
 
-    @Nullable
+    @SuppressWarnings("NullAway")
     MBeanAttributeInfo getMBeanAttributeInfo() {
       try {
         return new MBeanAttributeInfo(name, description, getter, setter);
@@ -118,27 +117,22 @@ private void collectAttributeInfo(Object bean) {
         .forEach(ai -> attributeMap.put(ai.name, ai));
   }
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   private AttributeInfo getAttributeInfo(Method m) {
     ManagedAttribute ma = m.getAnnotation(ManagedAttribute.class);
     if (ma == null) {
       return null;
     }
     try {
       String name = "".equals(ma.name()) ? m.getName() : ma.name();
-      Method getter = findGetter(m);
-      Method setter = findSetter(m);
-      if (getter == null || setter == null) {
-        return null;
-      }
-      return new AttributeInfo(name, ma.description(), getter, setter);
+      return new AttributeInfo(name, ma.description(), findGetter(m), findSetter(m));
     } catch (Throwable t) {
       LOG.severe("Error during execution: " + t.getMessage());
       return null;
     }
   }
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   private Method findGetter(Method annotatedMethod) {
     ManagedAttribute ma = annotatedMethod.getAnnotation(ManagedAttribute.class);
     try {
@@ -160,7 +154,7 @@ private Method findGetter(Method annotatedMethod) {
     }
   }
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   private Method findSetter(Method annotatedMethod) {
     ManagedAttribute ma = annotatedMethod.getAnnotation(ManagedAttribute.class);
     if (!"".equals(ma.setter())) {
@@ -180,7 +174,7 @@ private Method findSetter(Method annotatedMethod) {
     return null;
   }
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   private Method findMethod(Class<?> cls, String name) {
     return Stream.of(cls.getMethods())
         .filter(m -> m.getName().equals(name))
@@ -195,7 +189,7 @@ private void collectOperationInfo(Object bean) {
         .forEach(oi -> operationMap.put(oi.name, oi));
   }
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   private OperationInfo getOperationInfo(Method m) {
     ManagedOperation mo = m.getAnnotation(ManagedOperation.class);
     if (mo == null) {
@@ -225,15 +219,11 @@ private ObjectName generateObjectName(Object bean) {
     }
   }
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   @Override
   public Object getAttribute(String attribute) {
-    AttributeInfo attributeInfo = attributeMap.get(attribute);
-    if (attributeInfo == null) {
-      return null;
-    }
     try {
-      Object res = attributeInfo.getter.invoke(bean);
+      Object res = attributeMap.get(attribute).getter.invoke(bean);
       if (res instanceof Map<?, ?>) {
         return ((Map<?, ?>) res)
             .entrySet().stream()
@@ -249,14 +239,11 @@ public Object getAttribute(String attribute) {
     }
   }
 
+  @SuppressWarnings("NullAway")
   @Override
   public void setAttribute(Attribute attribute) {
-    AttributeInfo attributeInfo = attributeMap.get(attribute.getName());
-    if (attributeInfo == null) {
-      return;
-    }
     try {
-      attributeInfo.setter.invoke(bean, attribute.getValue());
+      attributeMap.get(attribute.getName()).setter.invoke(bean, attribute.getValue());
     } catch (IllegalAccessException | InvocationTargetException e) {
       LOG.severe("Error during execution: " + e.getMessage());
     }
@@ -277,21 +264,17 @@ public AttributeList getAttributes(String[] attributes) {
     return resultList;
   }
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   @Override
   public AttributeList setAttributes(AttributeList attributes) {
     return null;
   }
 
-  @Nullable
+  @SuppressWarnings("NullAway")
   @Override
   public Object invoke(String actionName, Object[] params, String[] signature) {
-    OperationInfo operationInfo = operationMap.get(actionName);
-    if (operationInfo == null) {
-      return null;
-    }
     try {
-      return operationInfo.method.invoke(bean, params);
+      return operationMap.get(actionName).method.invoke(bean, params);
     } catch (IllegalAccessException | InvocationTargetException e) {
       LOG.severe("Error during execution: " + e.getMessage());
       return null;