WriteDriverLogToConsole

Internal variable to avoid using
the stream when logs are sent to a file.

Not exposed to the user.

Author: diemol

dotnet/src/webdriver/DriverService.cs

@@ -155,11 +155,10 @@ public int ProcessId
     public string? DriverServicePath { get; set; }
 
     /// <summary>
-    /// Gets or sets a value indicating whether the driver process console output should be logged
-    /// to the console. Defaults to <see langword="false"/>, meaning console output from the
-    /// driver will be suppressed.
+    /// Collects the driver log output and writes it to the console. Defaults to <see langword="true"/>.
+    /// Internal variable to avoid using the stream when logs are sent to a file.
     /// </summary>
-    public bool LogToConsole { get; set; } = false;
+    protected bool WriteDriverLogToConsole { get; set; } = true;
 
     /// <summary>
     /// Gets the command-line arguments for the driver service.
@@ -253,8 +252,8 @@ public void Start()
         this.driverServiceProcess.StartInfo.UseShellExecute = false;
         this.driverServiceProcess.StartInfo.CreateNoWindow = this.HideCommandPromptWindow;
 
-        this.driverServiceProcess.StartInfo.RedirectStandardOutput = this.LogToConsole;
-        this.driverServiceProcess.StartInfo.RedirectStandardError = this.LogToConsole;
+        this.driverServiceProcess.StartInfo.RedirectStandardOutput = this.WriteDriverLogToConsole;
+        this.driverServiceProcess.StartInfo.RedirectStandardError = this.WriteDriverLogToConsole;
 
         DriverProcessStartingEventArgs eventArgs = new DriverProcessStartingEventArgs(this.driverServiceProcess.StartInfo);
         this.OnDriverProcessStarting(eventArgs);
@@ -318,12 +317,12 @@ protected virtual void OnDriverProcessStarted(DriverProcessStartedEventArgs even
             throw new ArgumentNullException(nameof(eventArgs), "eventArgs must not be null");
         }
 
-        if (this.LogToConsole && eventArgs.StandardOutputStreamReader != null)
+        if (this.WriteDriverLogToConsole && eventArgs.StandardOutputStreamReader != null)
         {
             _ = Task.Run(() => ReadStreamAsync(eventArgs.StandardOutputStreamReader, "stdout"));
         }
 
-        if (this.LogToConsole && eventArgs.StandardErrorStreamReader != null)
+        if (this.WriteDriverLogToConsole && eventArgs.StandardErrorStreamReader != null)
         {
             _ = Task.Run(() => ReadStreamAsync(eventArgs.StandardErrorStreamReader, "stderr"));
         }

dotnet/src/webdriver/Firefox/FirefoxDriverService.cs

@@ -206,6 +206,7 @@ protected override void OnDriverProcessStarting(DriverProcessStartingEventArgs e
     {
         if (!string.IsNullOrEmpty(this.LogPath))
         {
+            this.WriteDriverLogToConsole = false;
             string? directory = Path.GetDirectoryName(this.LogPath);
             if (!string.IsNullOrEmpty(directory) && !Directory.Exists(directory))
             {

dotnet/test/firefox/FirefoxDriverServiceTest.cs

@@ -21,6 +21,7 @@
 using System.Collections.Generic;
 using NUnit.Framework;
 using System.IO;
+using System.Linq;
 using OpenQA.Selenium.Internal.Logging;
 
 namespace OpenQA.Selenium.Firefox;
@@ -55,13 +56,14 @@ public void ShouldRedirectGeckoDriverLogsToFile()
     {
         FirefoxOptions options = new FirefoxOptions();
         string logPath = Path.GetTempFileName();
-        options.LogLevel = FirefoxDriverLogLevel.Trace;
+        options.LogLevel = FirefoxDriverLogLevel.Info;
 
         FirefoxDriverService service = FirefoxDriverService.CreateDefaultService();
         service.LogPath = logPath;
 
         IWebDriver firefoxDriver = new FirefoxDriver(service, options);
-
+        firefoxDriver.Quit();
+        
         try
         {
             Assert.That(File.Exists(logPath), Is.True);
@@ -70,7 +72,6 @@ public void ShouldRedirectGeckoDriverLogsToFile()
         }
         finally
         {
-            firefoxDriver.Quit();
             File.Delete(logPath);
         }
     }
@@ -83,14 +84,13 @@ public void ShouldRedirectGeckoDriverLogsToConsole()
         options.LogLevel = FirefoxDriverLogLevel.Info;
 
         FirefoxDriverService service = FirefoxDriverService.CreateDefaultService();
-        service.LogToConsole = true;
 
         IWebDriver firefoxDriver = new FirefoxDriver(service, options);
 
         try
         {
             Assert.That(testLogHandler.Events, Has.Count.AtLeast(1));
-            Assert.That(testLogHandler.Events[0].Message, Does.Contain("geckodriver"));
+            Assert.That(testLogHandler.Events.Any(e => e.Message.Contains("geckodriver")), Is.True);
         }
         finally
         {