Skip to content

Commit 2e386b9

Browse files
committed
enable other passing tests for edge and chrome
1 parent 15924f1 commit 2e386b9

File tree

1 file changed

+9
-6
lines changed

1 file changed

+9
-6
lines changed

py/test/selenium/webdriver/common/bidi_webextension_tests.py

Lines changed: 9 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -121,24 +121,27 @@ def test_install_base64_extension_path(driver, pages):
121121
uninstall_extension_and_verify_extension_uninstalled(driver, ext_info)
122122

123123

124-
@pytest.mark.xfail_chrome
125-
@pytest.mark.xfail_edge
126124
def test_install_unsigned_extension(driver, pages):
127125
"""Test installing an unsigned extension."""
128126
path = os.path.join(extensions, "webextensions-selenium-example")
129127

130-
ext_info = install_extension(driver, path=path)
128+
if driver.capabilities["browserName"].lower() in ["chrome", "microsoftedge"]:
129+
ext_info = driver.webextension.install(path=path)
130+
else:
131+
ext_info = install_extension(driver, path=path)
131132
verify_extension_injection(driver, pages)
132133
uninstall_extension_and_verify_extension_uninstalled(driver, ext_info)
133134

134135

135-
@pytest.mark.xfail_chrome
136-
@pytest.mark.xfail_edge
137136
def test_install_with_extension_id_uninstall(driver, pages):
138137
"""Test uninstalling an extension using just the extension ID."""
139138
path = os.path.join(extensions, EXTENSION_PATH)
140139

141-
ext_info = install_extension(driver, path=path)
140+
if driver.capabilities["browserName"].lower() in ["chrome", "microsoftedge"]:
141+
ext_info = driver.webextension.install(path=path)
142+
else:
143+
ext_info = install_extension(driver, path=path)
144+
142145
extension_id = ext_info.get("extension")
143146

144147
# Uninstall using the extension ID

0 commit comments

Comments
 (0)