Skip to content

Commit 2e63ee6

Browse files
committed
Fixing warnings in IE driver for 64-bit compilation
1 parent 7a74dbf commit 2e63ee6

6 files changed

+8
-9
lines changed

cpp/iedriver/CommandHandlers/ExecuteAsyncScriptCommandHandler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -58,7 +58,7 @@ void ExecuteAsyncScriptCommandHandler::ExecuteInternal(
5858

5959
Json::Value json_args = args_parameter_iterator->second;
6060

61-
int timeout_value = executor.async_script_timeout();
61+
unsigned long long timeout_value = executor.async_script_timeout();
6262
std::wstring timeout = std::to_wstring(static_cast<long long>(timeout_value));
6363

6464
std::wstring script_body = StringUtilities::ToWString(script_parameter_iterator->second.asString());

cpp/iedriver/CommandHandlers/FindChildElementCommandHandler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ void FindChildElementCommandHandler::ExecuteInternal(
8585
if (status_code == WD_SUCCESS) {
8686
Json::Value found_element;
8787

88-
int timeout = executor.implicit_wait_timeout();
88+
int timeout = static_cast<int>(executor.implicit_wait_timeout());
8989
clock_t end = clock() + (timeout / 1000 * CLOCKS_PER_SEC);
9090
if (timeout > 0 && timeout < 1000) {
9191
end += 1 * CLOCKS_PER_SEC;

cpp/iedriver/CommandHandlers/FindChildElementsCommandHandler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ void FindChildElementsCommandHandler::ExecuteInternal(
8484
if (status_code == WD_SUCCESS) {
8585
Json::Value found_elements(Json::arrayValue);
8686

87-
int timeout = executor.implicit_wait_timeout();
87+
int timeout = static_cast<int>(executor.implicit_wait_timeout());
8888
clock_t end = clock() + (timeout / 1000 * CLOCKS_PER_SEC);
8989
if (timeout > 0 && timeout < 1000) {
9090
end += 1 * CLOCKS_PER_SEC;

cpp/iedriver/CommandHandlers/FindElementCommandHandler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void FindElementCommandHandler::ExecuteInternal(
7070
return;
7171
}
7272

73-
int timeout = executor.implicit_wait_timeout();
73+
int timeout = static_cast<int>(executor.implicit_wait_timeout());
7474
clock_t end = clock() + (timeout / 1000 * CLOCKS_PER_SEC);
7575
if (timeout > 0 && timeout < 1000) {
7676
end += 1 * CLOCKS_PER_SEC;

cpp/iedriver/CommandHandlers/FindElementsCommandHandler.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -70,7 +70,7 @@ void FindElementsCommandHandler::ExecuteInternal(
7070
return;
7171
}
7272

73-
int timeout = executor.implicit_wait_timeout();
73+
int timeout = static_cast<int>(executor.implicit_wait_timeout());
7474
clock_t end = clock() + (timeout / 1000 * CLOCKS_PER_SEC);
7575
if (timeout > 0 && timeout < 1000) {
7676
end += 1 * CLOCKS_PER_SEC;

cpp/iedriver/CommandHandlers/NewSessionCommandHandler.cpp

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -783,15 +783,15 @@ bool NewSessionCommandHandler::ValidateCapabilities(
783783
}
784784
std::string proxy_type = proxy[proxy_setting].asString();
785785
if (proxy_type != "pac" &&
786-
proxy_type != "noproxy" &&
786+
proxy_type != "direct" &&
787787
proxy_type != "autodetect" &&
788788
proxy_type != "system" &&
789789
proxy_type != "manual") {
790790
*error_message = "Invalid capabilities in " +
791791
capability_set_name + ": " +
792792
"a proxy type named " + proxy_type +
793793
" is specified, but proxy type must be " +
794-
"'pac', 'noproxy', 'autodetect', 'system', " +
794+
"'pac', 'direct', 'autodetect', 'system', " +
795795
"or 'manual'";
796796
return false;
797797
}
@@ -815,8 +815,7 @@ bool NewSessionCommandHandler::ValidateCapabilities(
815815
continue;
816816
}
817817

818-
if (proxy_setting == "noProxy")
819-
{
818+
if (proxy_setting == "noProxy") {
820819
if (!this->ValidateCapabilityType(proxy,
821820
proxy_setting,
822821
Json::ValueType::arrayValue,

0 commit comments

Comments
 (0)