Skip to content

Commit 2ea15c8

Browse files
committed
[py] Fix test
1 parent 4e3b50f commit 2ea15c8

File tree

1 file changed

+8
-5
lines changed

1 file changed

+8
-5
lines changed

py/test/selenium/webdriver/common/bidi_network_tests.py

Lines changed: 8 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,7 @@
1717

1818
import pytest
1919

20+
from selenium.common.exceptions import WebDriverException
2021
from selenium.webdriver.common.bidi.browsing_context import ReadinessState
2122
from selenium.webdriver.common.bidi.network import Request
2223
from selenium.webdriver.common.by import By
@@ -101,17 +102,19 @@ def test_remove_auth_handler(driver):
101102
@pytest.mark.xfail_firefox(reason="Data URLs in Network requests are not implemented in Firefox yet")
102103
def test_handler_with_data_url_request(driver, pages):
103104
data_requests = []
105+
exceptions = []
104106

105107
def callback(request: Request):
106108
if request.url.startswith("data:"):
107109
data_requests.append(request)
108-
request.continue_request()
110+
try:
111+
request.continue_request()
112+
except WebDriverException as e:
113+
exceptions.append(e)
109114

110115
driver.network.add_request_handler("before_request", callback)
111116
url = pages.url("data_url.html")
112117
driver.browsing_context.navigate(context=driver.current_window_handle, url=url, wait=ReadinessState.COMPLETE)
113-
114-
# Assert that the BiDi event was captured.
115-
assert len(data_requests) > 0
116-
# Assert that the image is displayed.
117118
assert driver.find_element(By.ID, "data-url-image").is_displayed()
119+
assert len(data_requests) > 0, "BiDi event not captured"
120+
assert len(exceptions) == 0, "Exception raised when continuing request in callback"

0 commit comments

Comments
 (0)