Skip to content

Commit 314b458

Browse files
committed
Add test for continue without auth and cancel auth
1 parent 28cf363 commit 314b458

File tree

4 files changed

+34
-3
lines changed

4 files changed

+34
-3
lines changed

rb/lib/selenium/webdriver/bidi/network.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -60,7 +60,7 @@ def continue_with_auth(request_id, username, password)
6060
)
6161
end
6262

63-
def continue_with_auth_no_credentials(request_id)
63+
def continue_without_auth(request_id)
6464
@bidi.send_cmd(
6565
'network.continueWithAuth',
6666
'request' => request_id,

rb/sig/lib/selenium/webdriver/bidi/network.rbs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -14,12 +14,12 @@ module Selenium
1414

1515
def cancel_auth: -> untyped
1616

17-
def continue_with_auth_no_credentials: -> untyped
18-
1917
def continue_with_request: (**untyped args) -> untyped
2018

2119
def continue_with_response: (**untyped args) -> untyped
2220

21+
def continue_without_auth: -> untyped
22+
2323
def remove_intercept: (String intercept) -> untyped
2424

2525
def continue_with_auth: (String request_id, String username, String password) -> untyped

rb/spec/integration/selenium/webdriver/bidi/network_spec.rb

Lines changed: 27 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -57,6 +57,33 @@ class BiDi
5757
end
5858
end
5959

60+
it 'continues without auth' do
61+
reset_driver!(web_socket_url: true) do |driver|
62+
network = described_class.new(driver.bidi)
63+
network.add_intercept(phases: [described_class::PHASES[:auth_required]])
64+
network.on(:auth_required) do |event|
65+
request_id = event['request']['request']
66+
network.continue_without_auth(request_id)
67+
end
68+
69+
expect { driver.navigate.to url_for('basicAuth') }.to raise_error(Error::WebDriverError)
70+
end
71+
end
72+
73+
it 'cancels auth' do
74+
reset_driver!(web_socket_url: true) do |driver|
75+
network = described_class.new(driver.bidi)
76+
network.add_intercept(phases: [described_class::PHASES[:auth_required]])
77+
network.on(:auth_required) do |event|
78+
request_id = event['request']['request']
79+
network.cancel_auth(request_id)
80+
end
81+
82+
driver.navigate.to url_for('basicAuth')
83+
expect(driver.find_element(tag_name: 'pre').text).to eq('Login please')
84+
end
85+
end
86+
6087
it 'continues with request' do
6188
reset_driver!(web_socket_url: true) do |driver|
6289
network = described_class.new(driver.bidi)

rb/spec/integration/selenium/webdriver/network_spec.rb

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -59,6 +59,8 @@ module WebDriver
5959
reset_driver!(web_socket_url: true) do |driver|
6060
network = described_class.new(driver)
6161
network.add_request_handler
62+
driver.navigate.to url_for('formPage.html')
63+
expect(driver.find_element(name: 'login')).to be_displayed
6264
expect(network.callbacks.count).to be 1
6365
end
6466
end
@@ -86,6 +88,8 @@ module WebDriver
8688
reset_driver!(web_socket_url: true) do |driver|
8789
network = described_class.new(driver)
8890
network.add_response_handler
91+
driver.navigate.to url_for('formPage.html')
92+
expect(driver.find_element(name: 'login')).to be_displayed
8993
expect(network.callbacks.count).to be 1
9094
end
9195
end

0 commit comments

Comments
 (0)