Skip to content

Commit 31cbb0d

Browse files
committed
Remove deprecated :service_log_path driver initialization argument
It has been deprecated since 3.3.0. Use driver_opts: {log_path: ''} instead.
1 parent d59fe65 commit 31cbb0d

File tree

2 files changed

+0
-13
lines changed

2 files changed

+0
-13
lines changed

rb/lib/selenium/webdriver/chrome/driver.rb

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -37,11 +37,6 @@ def initialize(opts = {})
3737
driver_opts = opts.delete(:driver_opts) || {}
3838
port = opts.delete(:port) || Service::DEFAULT_PORT
3939

40-
if opts.key? :service_log_path
41-
WebDriver.logger.deprecate ':service_log_path', "driver_opts: {log_path: '#{opts[:service_log_path]}'}"
42-
driver_opts[:log_path] = opts.delete :service_log_path
43-
end
44-
4540
@service = Service.new(driver_path, port, driver_opts)
4641
@service.start
4742
opts[:url] = @service.uri

rb/spec/unit/selenium/webdriver/chrome/service_spec.rb

Lines changed: 0 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -67,14 +67,6 @@ module Chrome
6767
driver = Driver.new(http_client: http, driver_opts: driver_opts)
6868
expect(driver.instance_variable_get("@service").instance_variable_get("@extra_args")).to eq args
6969
end
70-
71-
it 'deprecates `service_log_path`' do
72-
message = %r{\[DEPRECATION\] `:service_log_path` is deprecated. Use `driver_opts: {log_path: \/path\/to\/log}`}
73-
74-
expect(WebDriver.logger).to receive(:deprecate).with(':service_log_path', "driver_opts: {log_path: '/path/to/log'}")
75-
@driver = Driver.new(http_client: http, service_log_path: "/path/to/log")
76-
expect(@driver.instance_variable_get("@service").instance_variable_get("@extra_args")).to eq ["--log-path=/path/to/log"]
77-
end
7870
end
7971
end # Chrome
8072
end # WebDriver

0 commit comments

Comments
 (0)