[dotnet] Obsolete setters and constructors on Response that are not conducive to immutability (#15107)

* [dotnet] Obsoletes setters on `Response` type

* [dotnet] Obsolete constructors on `Response` that are not conducive to immutability

* Avoid obsolete `Response` constructor

Author: RenderMichael

dotnet/src/webdriver/Remote/HttpCommandExecutor.cs

@@ -325,7 +325,8 @@ private Response CreateResponse(HttpResponseInfo responseInfo)
 
             if (response.Value is string valueString)
             {
-                response.Value = valueString.Replace("\r\n", "\n").Replace("\n", Environment.NewLine);
+                valueString = valueString.Replace("\r\n", "\n").Replace("\n", Environment.NewLine);
+                response = new Response(response.SessionId, valueString, response.Status);
             }
 
             return response;

dotnet/src/webdriver/Response.cs

@@ -42,6 +42,7 @@ public class Response
         /// <summary>
         /// Initializes a new instance of the <see cref="Response"/> class
         /// </summary>
+        [Obsolete("Set all values using the Response(string, object, WebDriverResult) constructor instead. This constructor will be removed in Selenium 4.30")]
         public Response()
         {
         }
@@ -50,6 +51,7 @@ public Response()
         /// Initializes a new instance of the <see cref="Response"/> class
         /// </summary>
         /// <param name="sessionId">Session ID in use</param>
+        [Obsolete("Set all values using the Response(string, object, WebDriverResult) constructor instead. This constructor will be removed in Selenium 4.30")]
         public Response(SessionId? sessionId)
         {
             this.SessionId = sessionId?.ToString();
@@ -136,18 +138,35 @@ public static Response FromJson(string value)
         /// <summary>
         /// Gets or sets the value from JSON.
         /// </summary>
-        public object? Value { get; set; }
+        public object? Value
+        {
+            get;
+
+            [Obsolete("The Response type will be immutable and this setter will be removed in Selenium 4.30")]
+            set;
+        }
 
         /// <summary>
         /// Gets or sets the session ID.
         /// </summary>
-        public string? SessionId { get; set; }
+        public string? SessionId
+        {
+            get;
+
+            [Obsolete("The Response type will be immutable and this setter will be removed in Selenium 4.30")]
+            set;
+        }
 
         /// <summary>
         /// Gets or sets the status value of the response.
         /// </summary>
-        public WebDriverResult Status { get; set; }
+        public WebDriverResult Status
+        {
+            get;
 
+            [Obsolete("The Response type will be immutable and this setter will be removed in Selenium 4.30")]
+            set;
+        }
 
         /// <summary>
         /// Returns a new <see cref="Response"/> from a JSON-encoded string.