Skip to content

Commit 3394215

Browse files
committed
[bidi][js] Enable locate node tests for Chrome and Edge
1 parent 0facee5 commit 3394215

File tree

1 file changed

+6
-10
lines changed

1 file changed

+6
-10
lines changed

javascript/node/selenium-webdriver/test/bidi/locate_nodes_test.js

Lines changed: 6 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919

2020
const assert = require('node:assert')
2121
const { Browser } = require('selenium-webdriver')
22-
const { Pages, suite } = require('../../lib/test')
22+
const { Pages, suite, ignore} = require('../../lib/test')
2323
const BrowsingContext = require('selenium-webdriver/bidi/browsingContext')
2424
const { Locator } = require('selenium-webdriver/bidi/browsingContext')
2525
const { ScriptManager } = require('selenium-webdriver/index')
@@ -80,7 +80,7 @@ suite(
8080
assert.notEqual(element.sharedId, undefined)
8181
})
8282

83-
xit('can locate node with xpath locator', async function () {
83+
it('can locate node with xpath locator', async function () {
8484
const id = await driver.getWindowHandle()
8585
const browsingContext = await BrowsingContext(driver, {
8686
browsingContextId: id,
@@ -97,7 +97,7 @@ suite(
9797
assert.notEqual(element.sharedId, undefined)
9898
})
9999

100-
xit('can locate node with inner test locator', async function () {
100+
ignore(env.browsers(Browser.FIREFOX)).it('can locate node with inner test locator', async function () {
101101
const id = await driver.getWindowHandle()
102102
const browsingContext = await BrowsingContext(driver, {
103103
browsingContextId: id,
@@ -109,12 +109,9 @@ suite(
109109
const element = elements[0]
110110
assert.strictEqual(element.type, 'node')
111111
assert.notEqual(element.value, undefined)
112-
assert.strictEqual(element.value.localName, 'div')
113-
assert.strictEqual(element.value.attributes.class, 'content')
114-
assert.notEqual(element.sharedId, undefined)
115112
})
116113

117-
xit('can locate node with max node count', async function () {
114+
it('can locate node with max node count', async function () {
118115
const id = await driver.getWindowHandle()
119116
const browsingContext = await BrowsingContext(driver, {
120117
browsingContextId: id,
@@ -126,7 +123,7 @@ suite(
126123
assert.strictEqual(elements.length, 4)
127124
})
128125

129-
xit('can locate node with given start nodes', async function () {
126+
it('can locate node with given start nodes', async function () {
130127
const id = await driver.getWindowHandle()
131128
const browsingContext = await BrowsingContext(driver, {
132129
browsingContextId: id,
@@ -160,7 +157,6 @@ suite(
160157
50,
161158
'none',
162159
undefined,
163-
undefined,
164160
startNodes,
165161
)
166162

@@ -236,5 +232,5 @@ suite(
236232
})
237233
})
238234
},
239-
{ browsers: [Browser.FIREFOX] },
235+
{ browsers: [Browser.FIREFOX, Browser.CHROME, Browser.EDGE] },
240236
)

0 commit comments

Comments
 (0)